Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1326403003: Re-factor two parameter version of endOfLine() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Re-factor two parameter version of endOfLine() This patch expands two version of |endOfLine()| which changes behavior with |mode| parameter into callers, one parameter version of |endOfLine()| and |logicalEndOfLine()| to simplify implementation as a preparation for templatizing |endOfLine()| and |logicalEndOfLine()| to introduce composed tree version. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201970

Patch Set 1 : 2015-09-09T17:59:43 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -38 lines) Patch
M Source/core/editing/VisibleUnits.cpp View 1 chunk +39 lines, -38 lines 3 comments Download

Messages

Total messages: 9 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-09 09:22:33 UTC) #2
hajimehoshi
https://codereview.chromium.org/1326403003/diff/1/Source/core/editing/VisibleUnits.cpp File Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/1326403003/diff/1/Source/core/editing/VisibleUnits.cpp#newcode1073 Source/core/editing/VisibleUnits.cpp:1073: // a xyz xyz xyz xyz xyz xyz xyz ...
5 years, 3 months ago (2015-09-09 10:59:09 UTC) #3
yosin_UTC9
On 2015/09/09 10:59:09, hajimehoshi wrote: > https://codereview.chromium.org/1326403003/diff/1/Source/core/editing/VisibleUnits.cpp > File Source/core/editing/VisibleUnits.cpp (right): > > https://codereview.chromium.org/1326403003/diff/1/Source/core/editing/VisibleUnits.cpp#newcode1073 > ...
5 years, 3 months ago (2015-09-09 11:07:35 UTC) #4
yosin_UTC9
https://codereview.chromium.org/1326403003/diff/1/Source/core/editing/VisibleUnits.cpp File Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/1326403003/diff/1/Source/core/editing/VisibleUnits.cpp#newcode1073 Source/core/editing/VisibleUnits.cpp:1073: // a xyz xyz xyz xyz xyz xyz xyz ...
5 years, 3 months ago (2015-09-09 11:08:49 UTC) #5
hajimehoshi
lgtm https://codereview.chromium.org/1326403003/diff/1/Source/core/editing/VisibleUnits.cpp File Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/1326403003/diff/1/Source/core/editing/VisibleUnits.cpp#newcode1073 Source/core/editing/VisibleUnits.cpp:1073: // a xyz xyz xyz xyz xyz xyz ...
5 years, 3 months ago (2015-09-09 11:11:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326403003/1
5 years, 3 months ago (2015-09-09 11:11:44 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 11:16:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201970

Powered by Google App Engine
This is Rietveld 408576698