Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1326403002: Selectors with unknown namespace prefixes should be dropped. (Closed)

Created:
5 years, 3 months ago by ramya.v
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears, pals, esprehn
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Selectors with unknown namespace prefixes should be dropped. Selectors with unknown namespace prefixes should be dropped. Added changes to check if a prefix encountered is unknown, and if it is so ignoring the selector. BUG=396945 Committed: https://crrev.com/1e8c4674fc5c9b848f5e9e3760ed7a6ba84172fc git-svn-id: svn://svn.chromium.org/blink/trunk@202015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Updated test cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/css-selector-text.html View 1 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/fast/css/namespaces/namespaces-invalid-prefix.xhtml View 1 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 4 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ramya.v
PTAL! Thanks
5 years, 3 months ago (2015-09-09 10:43:33 UTC) #2
Timothy Loh
On 2015/09/09 10:43:33, ramya.v wrote: > PTAL! > > Thanks lgtm
5 years, 3 months ago (2015-09-09 22:22:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326403002/20001
5 years, 3 months ago (2015-09-09 23:59:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202015
5 years, 3 months ago (2015-09-10 01:23:16 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:06:00 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1e8c4674fc5c9b848f5e9e3760ed7a6ba84172fc

Powered by Google App Engine
This is Rietveld 408576698