Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: chrome/browser/prefs/pref_service_syncable.h

Issue 1326353002: Remove dependency of PrefSyncableService on Profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pref_model_associator
Patch Set: Fixing ChromeOS and Linux compilation Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_metrics_service.cc ('k') | chrome/browser/prefs/pref_service_syncable.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_service_syncable.h
diff --git a/chrome/browser/prefs/pref_service_syncable.h b/chrome/browser/prefs/pref_service_syncable.h
index da52017911454d014c83796fee049b9e098056fa..f94a3028bad1c9fef6cf465a0c57ee26ea712b57 100644
--- a/chrome/browser/prefs/pref_service_syncable.h
+++ b/chrome/browser/prefs/pref_service_syncable.h
@@ -11,7 +11,6 @@
#include "components/pref_registry/pref_registry_syncable.h"
class PrefServiceSyncableObserver;
-class Profile;
namespace syncer {
class SyncableService;
@@ -22,18 +21,6 @@ class SyncableService;
// this PrefService.
class PrefServiceSyncable : public PrefService {
public:
- // PrefServiceSyncable is a PrefService with added integration for
- // sync, and knowledge of how to create an incognito
- // PrefService. For code that does not need to know about the sync
- // integration, you should use only the plain PrefService type.
- //
- // For this reason, Profile does not expose an accessor for the
- // PrefServiceSyncable type. Instead, you can use the utilities
- // below to retrieve the PrefServiceSyncable (or its incognito
- // version) from a Profile.
- static PrefServiceSyncable* FromProfile(Profile* profile);
- static PrefServiceSyncable* IncognitoFromProfile(Profile* profile);
-
// You may wish to use PrefServiceFactory or one of its subclasses
// for simplified construction.
PrefServiceSyncable(
« no previous file with comments | « chrome/browser/prefs/pref_metrics_service.cc ('k') | chrome/browser/prefs/pref_service_syncable.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698