Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 132633007: Return null in getLocationInfo for Drive files outside of virtual mount points. (Closed)

Created:
6 years, 10 months ago by mtomasz
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Return null in getLocationInfo for Drive files outside of virtual mount points. TEST=Tested manually, by setting the downloads directory to Drive, and then trying to install an unpacked extension. BUG=340925 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248925

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/file_manager/background/js/volume_manager.js View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mtomasz
@hirono: PTAL. Thanks!
6 years, 10 months ago (2014-02-05 04:38:54 UTC) #1
hirono
lgtm!
6 years, 10 months ago (2014-02-05 04:46:32 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 10 months ago (2014-02-05 04:47:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/132633007/30001
6 years, 10 months ago (2014-02-05 04:54:21 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 08:39:17 UTC) #5
Message was sent while issue was closed.
Change committed as 248925

Powered by Google App Engine
This is Rietveld 408576698