Source/core/paint/DeprecatedPaintLayer.cpp - Issue 1326183002: Merge ReferenceFilter into Filter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1326183002: Merge ReferenceFilter into Filter (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | Source/core/paint/FilterEffectBuilder.h » ('j') | Source/core/paint/SVGFilterPainter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/DeprecatedPaintLayer.cpp

diff --git a/Source/core/paint/DeprecatedPaintLayer.cpp b/Source/core/paint/DeprecatedPaintLayer.cpp

index 29c0f4bca89cbee090098a58324a430b07e04553..dcece708944bbffc37cce123bed47523d04bd5d8 100644

--- a/Source/core/paint/DeprecatedPaintLayer.cpp

+++ b/Source/core/paint/DeprecatedPaintLayer.cpp

@@ -78,7 +78,7 @@

#include "platform/geometry/FloatPoint3D.h"

#include "platform/geometry/FloatRect.h"

#include "platform/geometry/TransformState.h"

-#include "platform/graphics/filters/ReferenceFilter.h"

+#include "platform/graphics/filters/Filter.h"

#include "platform/graphics/filters/SourceGraphic.h"

#include "platform/transforms/ScaleTransformOperation.h"

#include "platform/transforms/TransformationMatrix.h"

@@ -2576,8 +2576,8 @@ FilterOperations computeFilterOperationsHandleReferenceFilters(const FilterOpera

if (filterOperation->type() != FilterOperation::REFERENCE)

continue;

ReferenceFilterOperation& referenceOperation = toReferenceFilterOperation(*filterOperation);

- // FIXME: Cache the ReferenceFilter if it didn't change.

- RefPtrWillBeRawPtr<ReferenceFilter> referenceFilter = ReferenceFilterBuilder::build(effectiveZoom, toElement(enclosingElement), nullptr, referenceOperation);

+ // FIXME: Cache the Filter if it didn't change.

+ RefPtrWillBeRawPtr<Filter> referenceFilter = ReferenceFilterBuilder::build(effectiveZoom, toElement(enclosingElement), nullptr, referenceOperation);

referenceOperation.setFilter(referenceFilter.release());

}

« no previous file with comments | « Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | Source/core/paint/FilterEffectBuilder.h » ('j') | Source/core/paint/SVGFilterPainter.cpp » ('J')