Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1326173002: MIPS:[turbofan] Improve boolean materialization compares. (Closed)

Created:
5 years, 3 months ago by dusan.milosavljevic
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS:[turbofan] Improve boolean materialization compares. Additionally, improve immediate operand matching for branches to avoid duplicated constant loading. Committed: https://crrev.com/49a40c220361aa9a62a2cd66100e9b3714135f48 Cr-Commit-Position: refs/heads/master@{#30604}

Patch Set 1 #

Patch Set 2 : Add myself to the authors. #

Patch Set 3 : Fix typos. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -57 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 3 chunks +82 lines, -26 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +24 lines, -5 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 3 chunks +84 lines, -22 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +24 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dusan.milosavljevic
PTAL.
5 years, 3 months ago (2015-09-04 16:49:10 UTC) #2
Benedikt Meurer
LGTM on the AUTHORS file. I'll leave it to Paul to review the patch.
5 years, 3 months ago (2015-09-04 17:43:34 UTC) #4
paul.l...
LGTM, thanks!
5 years, 3 months ago (2015-09-04 23:38:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326173002/40001
5 years, 3 months ago (2015-09-06 11:35:46 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-06 12:01:32 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-06 12:01:59 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/49a40c220361aa9a62a2cd66100e9b3714135f48
Cr-Commit-Position: refs/heads/master@{#30604}

Powered by Google App Engine
This is Rietveld 408576698