Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1326163002: Android Media Notification: remove "Touch to return" text. (Closed)

Created:
5 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 3 months ago
Reviewers:
Ian Wen, whywhat
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android Media Notification: remove "Touch to return" text. The notification only shows the origin. Touching the notification to return to the playing application is a very common pattern on Android. It is not required for us to reinforce it with text, making the notification less appealing. BUG=528202 Committed: https://crrev.com/ded797a710c1a07b06f8d84d697c54671a942b35 Cr-Commit-Position: refs/heads/master@{#347377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-09-04 10:20:51 UTC) #2
whywhat
lgtm
5 years, 3 months ago (2015-09-04 10:25:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326163002/1
5 years, 3 months ago (2015-09-04 10:31:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 10:54:31 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ded797a710c1a07b06f8d84d697c54671a942b35 Cr-Commit-Position: refs/heads/master@{#347377}
5 years, 3 months ago (2015-09-04 10:55:08 UTC) #7
Ian Wen
R.string.media_notification_text_no_link is only used in this class. If you remove getStatus(), don't you need to ...
5 years, 3 months ago (2015-09-04 17:38:22 UTC) #9
nyquist
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1307093008/ by nyquist@chromium.org. ...
5 years, 3 months ago (2015-09-04 23:41:31 UTC) #10
mlamouri (slow - plz ping)
On 2015/09/04 at 23:41:31, nyquist wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 3 months ago (2015-09-05 14:54:23 UTC) #11
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-09-05 14:58:50 UTC) #12
Message was sent while issue was closed.
On 2015/09/04 at 17:38:22, ianwen wrote:
> R.string.media_notification_text_no_link is only used in this class. If you
remove getStatus(), don't you need to remove the string in grd file as well?

I thought it was used by the webrtc notification. I would have swear I saw that
in cs but cs now says otherwise. I've added a note to myself to clean this up
next week.

Powered by Google App Engine
This is Rietveld 408576698