Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 132613004: Revert of Make sure Chrome_elf.dll imports are correct and that it the first import of chrome.exe (Closed)

Created:
6 years, 11 months ago by Cait (Slow)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert of Make sure Chrome_elf.dll imports are correct and that it the first import of chrome.exe (https://codereview.chromium.org/109483003/) Reason for revert: Tests failing on Win x64 bots. Original issue's description: > 1. Make sure chrome_elf.dll imports nothing besides kernel32, advapi32, and some msvc libs (DEBUG builds) > 2. Add gyp action and test to ensure chrome_elf.dll is always the first entry in chrome.exe's import table. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242834 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243048 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245197 TBR=robertshield@chromium.org,siggi@chromium.org,csharp@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -178 lines) Patch
D build/win/reorder-imports.py View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/chrome_exe.gypi View 4 chunks +2 lines, -37 lines 0 comments Download
M chrome_elf/chrome_elf.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D chrome_elf/elf_imports_unittest.cc View 1 chunk +0 lines, -94 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cait (Slow)
Created Revert of Make sure Chrome_elf.dll imports are correct and that it the first import ...
6 years, 11 months ago (2014-01-16 17:00:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/132613004/1
6 years, 11 months ago (2014-01-16 17:01:16 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 17:01:39 UTC) #3
Message was sent while issue was closed.
Change committed as 245214

Powered by Google App Engine
This is Rietveld 408576698