Check for cyclic reference in typedefs

tests/language/cyclic_typedef_test.dart

+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+ 
+typedef /*A();*/

[ahe, 2013/04/02 08:22:39]

These comments aren't helping.  I think it would be better if you added some
prose to describe what you're doing and removed the comments /*typedef*/, etc.

[Johnni Winther, 2013/04/02 09:40:14]

It looked good in Sublime Text 2!

Changed.

+
+// Cyclic through return type.
+/*typedef */ A /*A();*/ /// 01: compile-time error
+
+/*typedef*/ A( /*);*/
+
+// Cyclic through parameter type.
+/*typedef A(*/ A a /*);*/ /// 02: compile-time error
+
+// Cyclic through optional parameter type.
+/*typedef A(*/ [A a] /*);*/ /// 03: compile-time error
+
+// Cyclic through named parameter type.
+/*typedef A(*/ {A a} /*);*/ /// 04: compile-time error
+
+// Cyclic through generic parameter type.
+/*typedef A(*/ List<A> a /*);*/ /// 05: compile-time error
+
+// Cyclic through return type of function typed parameter.
+/*typedef A(*/ A f() /*);*/ /// 06: compile-time error
+
+// Cyclic through parameter type of function typed parameter.
+/*typedef A(*/ f(A a) /*);*/ /// 07: compile-time error
+
+// Cyclic through another typedef.
+/*typedef A(*/ B b /*);*/ /// 08: compile-time error
+
+// Cyclic through another more typedefs.
+/*typedef A(*/ C c /*);*/ /// 09: compile-time error
+
+/*typedef A(*/ );
+
+typedef B(A a);
+typedef C(B b);
+
+void testA(A a) {}
+
+void main() {
+  testA(null);
+}