Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: pkg/unittest/lib/interactive_html_config.dart

Issue 13261006: pkg/unittest: cleanup to logMessage (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rename the log method on Configuration to look like the others Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/unittest/lib/src/config.dart » ('j') | pkg/unittest/lib/src/config.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/interactive_html_config.dart
diff --git a/pkg/unittest/lib/interactive_html_config.dart b/pkg/unittest/lib/interactive_html_config.dart
index a1d05c0ff8af5ea5611f2c9fe186ee9cfa50abe5..0f7ff030c21bb297fe5499ad75ecc02382822c49 100644
--- a/pkg/unittest/lib/interactive_html_config.dart
+++ b/pkg/unittest/lib/interactive_html_config.dart
@@ -131,7 +131,7 @@ class ChildInteractiveHtmlConfiguration extends HtmlConfiguration {
* messages in turn get passed to this method, which adds
* a timestamp and posts them back to the parent window.
*/
- void logTestCaseMessage(TestCase testCase, String message) {
+ void onLogMessage(TestCase testCase, String message) {
int elapsed;
if (testCase == null) {
elapsed = -1;
@@ -359,7 +359,7 @@ class ParentInteractiveHtmlConfiguration extends HtmlConfiguration {
// Actually test logging is handled by the child, then posted
// back to the parent. So here we know that the [message] argument
// is in the format used by [_Message].
- void logTestCaseMessage(TestCase testCase, String message) {
+ void onLogMessage(TestCase testCase, String message) {
var msg = new _Message.fromString(message);
if (msg.elapsed < 0) { // No associated test case.
document.query('#otherlogs').nodes.add(
@@ -380,7 +380,7 @@ class ParentInteractiveHtmlConfiguration extends HtmlConfiguration {
if (!testCase.enabled) return;
super.onTestResult(testCase);
if (testCase.message != '') {
- logTestCaseMessage(testCase,
+ onLogMessage(testCase,
_Message.text(_Message.LOG, -1, testCase.message));
}
int id = testCase.id;
« no previous file with comments | « no previous file | pkg/unittest/lib/src/config.dart » ('j') | pkg/unittest/lib/src/config.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698