Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1326093005: Revert of Enable errorprone compiler on the chromium.fyi Android Builder. (Closed)

Created:
5 years, 3 months ago by mikecase (-- gone --)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Enable errorprone compiler on the chromium.fyi Android Builder. (patchset #4 id:60001 of https://codereview.chromium.org/1305303002/ ) Reason for revert: Causes Android Fyi builder to fail on compile. http://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29/builds/58667/steps/compile/logs/stdio Will investigates what is going wrong. Original issue's description: > Enable errorprone compiler on the chromium.fyi Android Builder. > > Enabling errorprone on this bot to test. If everything seems stable, > I will change errorprone to be default for everyone. > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296611 TBR=phajdan.jr@chromium.org,luqui@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M scripts/slave/recipe_modules/chromium_android/chromium_config.py View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mikecase (-- gone --)
Created Revert of Enable errorprone compiler on the chromium.fyi Android Builder.
5 years, 3 months ago (2015-09-09 17:35:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326093005/1
5 years, 3 months ago (2015-09-09 17:35:37 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-09 17:35:38 UTC) #4
luqui
lgtm
5 years, 3 months ago (2015-09-09 21:31:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326093005/1
5 years, 3 months ago (2015-09-09 21:31:41 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 21:31:51 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296617

Powered by Google App Engine
This is Rietveld 408576698