build/config/sanitizers/sanitizers.gni - Issue 1326053003: port cfi to gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 1326053003: port cfi to gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert gn changes; start using toolchain_os; fix use_cfi_diag=true Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/sanitizers/sanitizers.gni

diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni

index d5374e1a0ffb83f6b019d14e05f0f65c910da7b7..5217a74168ba1c618db85acb4609bd479108a764 100644

--- a/build/config/sanitizers/sanitizers.gni

+++ b/build/config/sanitizers/sanitizers.gni

@@ -22,6 +22,13 @@ declare_args() {

# errors. Only works on Windows. See

# https://code.google.com/p/sawbuck/wiki/SyzyASanHowTo

is_syzyasan = false

+ # Compile with Control Flow Integrity to protect virtual calls and casts.

+ # See http://clang.llvm.org/docs/ControlFlowIntegrity.html

+ is_cfi = false

+ # Whether Control Flow Integrity prints diagnostics instead of crashing.

brettw 2015/09/10 23:16:34 Can you rephrase this comment to make more clear w

pcc 2015/09/11 02:38:56 Done.

+ use_cfi_diag = false

}

# MSan only links Chrome properly in release builds (brettw -- 9/1/2015). The

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »