build/toolchain/gcc_toolchain.gni - Issue 1326053003: port cfi to gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 1326053003: port cfi to gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable CFI when targeting nacl Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/gcc_toolchain.gni

diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni

index bb3846c3bb6bd817cd9b00ab770142c909203ca6..924bf1b0978689cf903562d34ead35533a893588 100644

--- a/build/toolchain/gcc_toolchain.gni

+++ b/build/toolchain/gcc_toolchain.gni

@@ -173,7 +173,7 @@ template("gcc_toolchain") {

tool("alink") {

rspfile = "{{output}}.rsp"

- command = "rm -f {{output}} && $ar rcs {{output}} @$rspfile"

+ command = "rm -f {{output}} && $ar rcs {{arflags}} {{output}} @$rspfile"

description = "AR {{output}}"

rspfile_content = "{{inputs}}"

outputs = [