Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 1326053002: DevTools: negative time on network filmstrip when reloading page while loading. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/components_lazy/FilmStripModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index b865cd8989d980953fd66eb282510490eeb1465a..dfa0c597444b17460bde9c6cb9a746847e8db65a 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -299,7 +299,7 @@ WebInspector.NetworkPanel.prototype = {
this._filmStripView = new WebInspector.FilmStripView();
this._filmStripView.setMode(WebInspector.FilmStripView.Modes.FrameBased);
this._filmStripView.element.classList.add("network-film-strip");
- this._filmStripRecorder = new WebInspector.NetworkPanel.FilmStripRecorder(this._filmStripView);
+ this._filmStripRecorder = new WebInspector.NetworkPanel.FilmStripRecorder(this._networkLogView.timeCalculator(), this._filmStripView);
this._filmStripView.show(this._searchableView.element, this._searchableView.element.firstElementChild);
this._filmStripView.addEventListener(WebInspector.FilmStripView.Events.FrameSelected, this._onFilmFrameSelected, this);
this._filmStripView.addEventListener(WebInspector.FilmStripView.Events.FrameEnter, this._onFilmFrameEnter, this);
@@ -670,10 +670,12 @@ WebInspector.NetworkPanelFactory.prototype = {
/**
* @constructor
* @implements {WebInspector.TracingManagerClient}
+ * @param {!WebInspector.NetworkTimeCalculator} timeCalculator
* @param {!WebInspector.FilmStripView} filmStripView
*/
-WebInspector.NetworkPanel.FilmStripRecorder = function(filmStripView)
+WebInspector.NetworkPanel.FilmStripRecorder = function(timeCalculator, filmStripView)
{
+ this._timeCalculator = timeCalculator;
this._filmStripView = filmStripView;
}
@@ -703,7 +705,7 @@ WebInspector.NetworkPanel.FilmStripRecorder.prototype = {
if (!this._tracingModel)
return;
this._tracingModel.tracingComplete();
- this._callback(new WebInspector.FilmStripModel(this._tracingModel));
+ this._callback(new WebInspector.FilmStripModel(this._tracingModel, this._timeCalculator.minimumBoundary() * 1000));
delete this._callback;
},
« no previous file with comments | « Source/devtools/front_end/components_lazy/FilmStripModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698