Update BUILD.gn for [P]NaCl.

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/arm.gni")
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 import("//third_party/libvpx/libvpx_srcs.gni")
 import("//third_party/yasm/yasm_assemble.gni")
 
 if (is_posix && !is_mac) {
   os_category = "linux"
+} if (is_nacl) {

[Johann, 2015/09/03 02:14:51]

this doesn't seem necessary, but if you want to keep it should it be else if?

[Sergey Ulanov, 2015/09/03 04:25:20]

Actually with your other suggestion below os_category is not used in is_nacl
case, so I moved os_category inside !is_nacl if block below.

+  os_category = "nacl"
 } else {
   os_category = current_os
 }
 
 # Sets the architecture name for building libvpx.
 if (current_cpu == "x86") {
   cpu_arch_full = "ia32"
 } else if (current_cpu == "x64") {
   if (is_msan) {
     cpu_arch_full = "generic"
   } else {
     cpu_arch_full = "x64"
   }
 } else if (current_cpu == "arm") {
   if (arm_use_neon) {
     cpu_arch_full = "arm-neon"
   } else if (is_android) {
     cpu_arch_full = "arm-neon-cpu-detect"
   } else {
     cpu_arch_full = "arm"
   }
 } else {
   cpu_arch_full = current_cpu
 }
 
+if (os_category == "nacl") {

[Johann, 2015/09/03 02:14:51]

this could be if(is_nacl), yeah?

[Sergey Ulanov, 2015/09/03 04:25:20]

Done.

+  platform_include_dir =
+      "//third_party/libvpx/source/config/$os_category"

[Johann, 2015/09/03 02:14:51]

this could be hard coded source/config/nacl

[Sergey Ulanov, 2015/09/03 04:25:20]

Done.

+} else {
+  platform_include_dir =
+      "//third_party/libvpx/source/config/$os_category/$cpu_arch_full"
+}
+
 config("libvpx_config") {
   include_dirs = [
     "//third_party/libvpx/source/config",
-    "//third_party/libvpx/source/config/$os_category/$cpu_arch_full",
+    platform_include_dir,
     "//third_party/libvpx/source/libvpx",
     "$root_gen_dir/third_party/libvpx", # Provides vpx_rtcd.h.
   ]
 }
 
 # gn orders flags on a target before flags from configs. The default config
 # adds -Wall, and these flags have to be after -Wall -- so they need to come
 # from a config and can't be on the target directly.
 config("libvpx_warnings") {
   if (is_clang) {
@@ skipping 18 matching lines @@
 if (current_cpu == "x86" || current_cpu == "x64") {
   yasm_assemble("libvpx_yasm") {
     if (current_cpu == "x86") {
       sources = libvpx_srcs_x86_assembly
     } else if (current_cpu == "x64") {
       sources = libvpx_srcs_x86_64_assembly
     }
 
     defines = [ "CHROMIUM" ]
     include_dirs = [
-      "//third_party/libvpx/source/config/$os_category/$cpu_arch_full",
+      platform_include_dir,
       "//third_party/libvpx/source/config",
-     "//third_party/libvpx/source/libvpx",
+      "//third_party/libvpx/source/libvpx",
       target_gen_dir
     ]
   }
 }
 
 static_library("libvpx_intrinsics_mmx") {
   configs += [ ":libvpx_config" ]
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
   configs += [ ":libvpx_warnings" ]
@@ skipping 114 matching lines @@
     ]
   }
 }
 
 static_library("libvpx") {
   if (!is_debug && is_win && is_official_build) {
     configs -= [ "//build/config/compiler:optimize" ]
     configs += [ "//build/config/compiler:optimize_max" ]
   }
 
-  if (current_cpu == "x86") {
+  if (is_nacl) {
+    sources = libvpx_srcs_generic
+  } if (current_cpu == "x86") {

[Johann, 2015/09/03 02:14:51]

else if?

[Sergey Ulanov, 2015/09/03 04:25:20]

Yes, of course! Thanks for catching it! 

     sources = libvpx_srcs_x86
   } else if (current_cpu == "x64") {
     if (is_msan) {
       sources = libvpx_srcs_generic
     } else {
       sources = libvpx_srcs_x86_64
     }
   } else if (current_cpu == "mipsel") {
     sources = libvpx_srcs_mips
   } else if (current_cpu == "arm") {
@@ skipping 28 matching lines @@
   }
   if (is_android) {
     deps += [ "//third_party/android_tools:cpu_features" ]
   }
   if (current_cpu == "arm") {
     deps += [ ":libvpx_assembly_arm" ]
   }
 
   public_configs = [ ":libvpx_external_config" ]
 }