Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: runtime/bin/main.cc

Issue 1325963002: Don't stop the event handler (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 5b2c70b9c37aed5d9a58c8ff9efaf35bfc00f446..eaa30c4f5293da01a7ade5512dce7af6f3cdb183 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -111,7 +111,8 @@ static void ErrorExit(int exit_code, const char* format, ...) {
Dart_Cleanup();
DebuggerConnectionHandler::StopHandler();
- EventHandler::Stop();
+ // TODO(zra): Stop the EventHandler once thread shutdown is enabled.
+ // EventHandler::Stop();
exit(exit_code);
}
@@ -1045,7 +1046,8 @@ void main(int argc, char** argv) {
fprintf(stderr, "%s", "VM initialization failed\n");
fflush(stderr);
DebuggerConnectionHandler::StopHandler();
- EventHandler::Stop();
+ // TODO(zra): Stop the EventHandler once thread shutdown is enabled.
+ // EventHandler::Stop();
exit(kErrorExitCode);
}
@@ -1071,7 +1073,8 @@ void main(int argc, char** argv) {
free(error);
delete [] isolate_name;
DebuggerConnectionHandler::StopHandler();
- EventHandler::Stop();
+ // TODO(zra): Stop the EventHandler once thread shutdown is enabled.
+ // EventHandler::Stop();
exit((exit_code != 0) ? exit_code : kErrorExitCode);
}
delete [] isolate_name;
@@ -1178,7 +1181,8 @@ void main(int argc, char** argv) {
Dart_Cleanup();
DebuggerConnectionHandler::StopHandler();
- EventHandler::Stop();
+ // TODO(zra): Stop the EventHandler once thread shutdown is enabled.
+ // EventHandler::Stop();
// Free copied argument strings if converted.
if (argv_converted) {
« no previous file with comments | « no previous file | runtime/bin/process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698