Issue 132593005: skia: Stop overriding drawPosTextOnPath() on AnalysisCanvas.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132593005: skia: Stop overriding drawPosTextOnPath() on AnalysisCanvas. (Closed)

Created:
6 years, 11 months ago by tfarina

Modified:
6 years, 11 months ago

Reviewers:
bungeman-skia, Nico, reed1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

skia: Stop overriding drawPosTextOnPath() on AnalysisCanvas. drawPosTextOnPath() was deprecated on skia and is going to be deleted after no one is using it on Chrome. BUG=skia:1834 TEST=None, no functional changes R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244287

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -23 lines)			Patch
	M	skia/ext/analysis_canvas.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
	M	skia/ext/analysis_canvas.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Total messages: 6 (0 generated)

tfarina

Mike, Ben, may be one of you could approve this instead? Thanks!

6 years, 11 months ago (2014-01-10 21:54:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/132593005/1

6 years, 11 months ago (2014-01-10 22:03:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/132593005/1

6 years, 11 months ago (2014-01-10 23:38:22 UTC) #5

Message was sent while issue was closed.

Change committed as 244287