Issue 132593003: Fix errors in start with URL tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132593003: Fix errors in start with URL tests (Closed)

Created:
6 years, 11 months ago by aberent

Modified:
6 years, 11 months ago

Reviewers:
dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix errors in start with URL tests 1. Fix error in check for runnable pages in session_restore_with_url 2. Add page sets to google storage. Also had to change the page set, because when I tried to use the latest version of news.bbc.co.uk on mobile it was asking if I wanted to install the mobile app. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244014

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
M	tools/perf/measurements/session_restore_with_url.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/page_sets/data/startup_pages.json	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	tools/perf/page_sets/data/startup_pages_000.wpr.sha1	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/perf/page_sets/startup_pages.json	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/perf/page_sets/startup_pages_record.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/132593003/1

6 years, 11 months ago (2014-01-09 21:36:54 UTC) #3

Message was sent while issue was closed.

Change committed as 244014

Expand Messages | Collapse Messages