Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1325903004: CMAKE + install command (Closed)

Created:
5 years, 3 months ago by hal.canary
Modified:
5 years, 3 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : 2015-09-03 (Thursday) 17:05:13 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M cmake/CMakeLists.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M experimental/c-api-example/c.md View 1 1 chunk +14 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hal.canary
PTAL
5 years, 3 months ago (2015-09-03 15:10:44 UTC) #2
mtklein
I don't think it's a good idea to even vaguely indicate even in the most ...
5 years, 3 months ago (2015-09-03 15:13:24 UTC) #3
hal.canary
PTAL
5 years, 3 months ago (2015-09-03 16:14:15 UTC) #5
mtklein
https://codereview.chromium.org/1325903004/diff/1/experimental/c-api-example/c.md File experimental/c-api-example/c.md (right): https://codereview.chromium.org/1325903004/diff/1/experimental/c-api-example/c.md#newcode115 experimental/c-api-example/c.md:115: prefix="$HOME" # or /usr/local or wherever This seems too ...
5 years, 3 months ago (2015-09-03 16:32:06 UTC) #6
hal.canary
https://codereview.chromium.org/1325903004/diff/1/experimental/c-api-example/c.md File experimental/c-api-example/c.md (right): https://codereview.chromium.org/1325903004/diff/1/experimental/c-api-example/c.md#newcode115 experimental/c-api-example/c.md:115: prefix="$HOME" # or /usr/local or wherever On 2015/09/03 16:32:06, ...
5 years, 3 months ago (2015-09-03 21:05:24 UTC) #7
mtklein
lgtm
5 years, 3 months ago (2015-09-03 21:18:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325903004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325903004/20001
5 years, 3 months ago (2015-09-03 21:22:56 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 21:23:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5a9a5b3e7fc5bd79af55f22cb674e8d2d7021d9d

Powered by Google App Engine
This is Rietveld 408576698