Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1325893005: Rename DOMFormData to FormData. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi, yhirano
CC:
blink-reviews, tyoshino+watch_chromium.org, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive, kinuko+watch, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename DOMFormData to FormData. DOMFormData was an implementatio of FormData IDL interface. New name matches to the inteface. This CL has no behavior changes. BUG=528840 R=keishi@chromium.org Committed: https://crrev.com/3d843d0c77eb4a78d2e608f56331b7b4f4fc89bb git-svn-id: svn://svn.chromium.org/blink/trunk@202021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -481 lines) Patch
M Source/core/core.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
D Source/core/html/DOMFormData.h View 1 chunk +0 lines, -94 lines 0 comments Download
D Source/core/html/DOMFormData.cpp View 1 chunk +0 lines, -233 lines 0 comments Download
D Source/core/html/DOMFormDataTest.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
A + Source/core/html/FormData.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + Source/core/html/FormData.cpp View 10 chunks +19 lines, -19 lines 0 comments Download
M Source/core/html/FormData.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/FormDataList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormDataList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/FormDataTest.cpp View 3 chunks +7 lines, -8 lines 0 comments Download
M Source/core/loader/BeaconLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/BeaconLoader.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/loader/FormSubmission.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/beacon/NavigatorBeacon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/credentialmanager/PasswordCredential.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/credentialmanager/PasswordCredential.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/fetch/RequestInit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/fetch/Response.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebSearchableFormData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tkent
yhirano or keishi, would you review this please?
5 years, 3 months ago (2015-09-10 01:00:04 UTC) #2
keishi
LGTM
5 years, 3 months ago (2015-09-10 01:38:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325893005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325893005/1
5 years, 3 months ago (2015-09-10 01:45:35 UTC) #5
tkent
Committed patchset #1 (id:1) manually as 202021 (presubmit successful).
5 years, 3 months ago (2015-09-10 03:37:12 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:06:52 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3d843d0c77eb4a78d2e608f56331b7b4f4fc89bb

Powered by Google App Engine
This is Rietveld 408576698