Chromium Code Reviews

Unified Diff: src/base/platform/platform-linux.cc

Issue 1325853003: [heap,cctest] Fix CodeRange tests that call AllocateRawMemory directly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: src/base/platform/platform-linux.cc
diff --git a/src/base/platform/platform-linux.cc b/src/base/platform/platform-linux.cc
index 874c6dbc31b9b3bdd6cd285b5fcbfa7ff528cf8d..e2c321c07f09074aed4a49c0503b8e848c33ebbb 100644
--- a/src/base/platform/platform-linux.cc
+++ b/src/base/platform/platform-linux.cc
@@ -310,16 +310,19 @@ void VirtualMemory::Reset() {
bool VirtualMemory::Commit(void* address, size_t size, bool is_executable) {
+ CHECK(InVM(address, size));
Michael Lippautz 2015/09/01 14:52:58 Michi: Enforce on all platforms? DCHECK vs CHECK?
Michael Starzinger 2015/09/01 15:08:53 I am fine with CHECK here, as you mentioned offlin
Michael Lippautz 2015/09/01 15:19:35 Acknowledged.
return CommitRegion(address, size, is_executable);
}
bool VirtualMemory::Uncommit(void* address, size_t size) {
+ CHECK(InVM(address, size));
return UncommitRegion(address, size);
}
bool VirtualMemory::Guard(void* address) {
+ CHECK(InVM(address, OS::CommitPageSize()));
OS::Guard(address, OS::CommitPageSize());
return true;
}
« no previous file with comments | « src/base/platform/platform.h ('k') | src/heap/spaces.cc » ('j') | test/cctest/test-alloc.cc » ('J')

Powered by Google App Engine