[heap,cctest] Fix CodeRange tests that call AllocateRawMemory directly.

[heap,cctest] Fix CodeRange tests that use AllocateRawMemory directly.

* Enforce invariants on the way.
* Unmark flaky CodeRange test.

BUG=v8:4141
BUG=v8:3005
LOG=N

Committed: https://crrev.com/277795e28fa5f6b1d8348912a1c3d1cb742b5fa4
Cr-Commit-Position: refs/heads/master@{#30524}

[Michael Lippautz, 2015-09-01 14:52:58]

mlippautz@chromium.org changed reviewers:
+ machenbach@google.com, mstarzinger@chromium.org

[Michael Lippautz, 2015-09-01 14:52:58]

Only git gods know how long we have been "off by a couple pages" here.

https://codereview.chromium.org/1325853003/diff/40001/src/base/platform/platf...
File src/base/platform/platform-linux.cc (right):

https://codereview.chromium.org/1325853003/diff/40001/src/base/platform/platf...
src/base/platform/platform-linux.cc:313: CHECK(InVM(address, size));
Michi: Enforce on all platforms? DCHECK vs CHECK?

[Michael Starzinger, 2015-09-01 15:08:53]

LGTM. Nice catch.

https://codereview.chromium.org/1325853003/diff/40001/src/base/platform/platf...
File src/base/platform/platform-linux.cc (right):

https://codereview.chromium.org/1325853003/diff/40001/src/base/platform/platf...
src/base/platform/platform-linux.cc:313: CHECK(InVM(address, size));
On 2015/09/01 14:52:58, Michael Lippautz wrote:
> Michi: Enforce on all platforms? DCHECK vs CHECK?

I am fine with CHECK here, as you mentioned offline, we do a sys-call right
afterwards, so the overhead is negligible. I would be fine with keeping it to
Linux for now.

https://codereview.chromium.org/1325853003/diff/40001/test/cctest/test-alloc.cc
File test/cctest/test-alloc.cc (right):

https://codereview.chromium.org/1325853003/diff/40001/test/cctest/test-alloc....
test/cctest/test-alloc.cc:228: // The request size has to be at least 2 code
guard pages larger then the
nit: s/then/than/

[Michael Lippautz, 2015-09-01 15:19:35]

https://codereview.chromium.org/1325853003/diff/40001/src/base/platform/platf...
File src/base/platform/platform-linux.cc (right):

https://codereview.chromium.org/1325853003/diff/40001/src/base/platform/platf...
src/base/platform/platform-linux.cc:313: CHECK(InVM(address, size));
On 2015/09/01 15:08:53, Michael Starzinger wrote:
> On 2015/09/01 14:52:58, Michael Lippautz wrote:
> > Michi: Enforce on all platforms? DCHECK vs CHECK?
> 
> I am fine with CHECK here, as you mentioned offline, we do a sys-call right
> afterwards, so the overhead is negligible. I would be fine with keeping it to
> Linux for now.

Acknowledged.

https://codereview.chromium.org/1325853003/diff/40001/test/cctest/test-alloc.cc
File test/cctest/test-alloc.cc (right):

https://codereview.chromium.org/1325853003/diff/40001/test/cctest/test-alloc....
test/cctest/test-alloc.cc:228: // The request size has to be at least 2 code
guard pages larger then the
On 2015/09/01 15:08:53, Michael Starzinger wrote:
> nit: s/then/than/

Done.

[Michael Lippautz, 2015-09-01 17:09:18]

mlippautz@chromium.org changed reviewers:
+ machenbach@chromium.org
- machenbach@google.com

[Michael Hablich, 2015-09-01 17:10:03]

On 2015/09/01 15:19:35, Michael Lippautz wrote:
>
https://codereview.chromium.org/1325853003/diff/40001/src/base/platform/platf...
> File src/base/platform/platform-linux.cc (right):
> 
>
https://codereview.chromium.org/1325853003/diff/40001/src/base/platform/platf...
> src/base/platform/platform-linux.cc:313: CHECK(InVM(address, size));
> On 2015/09/01 15:08:53, Michael Starzinger wrote:
> > On 2015/09/01 14:52:58, Michael Lippautz wrote:
> > > Michi: Enforce on all platforms? DCHECK vs CHECK?
> > 
> > I am fine with CHECK here, as you mentioned offline, we do a sys-call right
> > afterwards, so the overhead is negligible. I would be fine with keeping it
to
> > Linux for now.
> 
> Acknowledged.
> 
>
https://codereview.chromium.org/1325853003/diff/40001/test/cctest/test-alloc.cc
> File test/cctest/test-alloc.cc (right):
> 
>
https://codereview.chromium.org/1325853003/diff/40001/test/cctest/test-alloc....
> test/cctest/test-alloc.cc:228: // The request size has to be at least 2 code
> guard pages larger then the
> On 2015/09/01 15:08:53, Michael Starzinger wrote:
> > nit: s/then/than/
> 
> Done.

Lgtm

[Michael Lippautz, 2015-09-01 17:11:18]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-09-01 17:11:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1325853003/#ps60001
(title: "Addressed comment")

[commit-bot: I haz the power, 2015-09-01 17:11:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325853003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325853003/60001

[commit-bot: I haz the power, 2015-09-01 17:22:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 17:22:14]

Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9341)

[Michael Lippautz, 2015-09-01 17:41:06]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-09-01 17:41:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, hablich@chromium.org
Link to the patchset: https://codereview.chromium.org/1325853003/#ps80001
(title: "Fix 2nd half of test-spaces/Regress3540 ;)")

[commit-bot: I haz the power, 2015-09-01 17:41:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325853003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325853003/80001

[commit-bot: I haz the power, 2015-09-01 18:39:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-01 18:39:39]

Patchset 5 (id:??) landed as
https://crrev.com/277795e28fa5f6b1d8348912a1c3d1cb742b5fa4
Cr-Commit-Position: refs/heads/master@{#30524}