Revert of [sqlite] Respect the gyp and gn component switch.

third_party/sqlite/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 declare_args() {
   # Controls whether the build should uses the version of sqlite3 library
   # shipped with the system (currently only supported on iOS) or the one
   # shipped with Chromium source.
   use_system_sqlite = is_ios
 }
 
 if (!use_system_sqlite) {
-  # TODO(shess): This cannot possibly be the right thing to do.  AFAICT it is
-  # only necessary so that WebDatabase can #include <sqlite3.h>.
   config("sqlite_config") {
     include_dirs = [ "." ]
   }
 
   config("sqlite_warnings") {
     cflags = []
     if (is_clang) {
       # sqlite contains a few functions that are unused, at least on
       # Windows with Chromium's sqlite patches applied
       # (interiorCursorEOF fts3EvalDeferredPhrase
       # fts3EvalSelectDeferred sqlite3Fts3InitHashTable
       # sqlite3Fts3InitTok).
       cflags += [ "-Wno-unused-function" ]
     }
     if (is_linux) {
       cflags += [
         # SQLite doesn"t believe in compiler warnings,
         # preferring testing.
         #   http://www.sqlite.org/faq.html#q17
         "-Wno-int-to-pointer-cast",
         "-Wno-pointer-to-int-cast",
       ]
     }
   }
 
-  component("sqlite_build") {
-    visibility = [ ":*" ]
-
+  source_set("sqlite") {
     sources = [
       "amalgamation/sqlite3.c",
       "amalgamation/sqlite3.h",
     ]
 
     cflags = []
     defines = [
       "SQLITE_ENABLE_FTS3",
       "SQLITE_DISABLE_FTS3_UNICODE",
       "SQLITE_DISABLE_FTS4_DEFERRED",
       "SQLITE_ENABLE_ICU",
       "SQLITE_ENABLE_MEMORY_MANAGEMENT",
       "SQLITE_SECURE_DELETE",
       "SQLITE_SEPARATE_CACHE_POOLS",
       "THREADSAFE",
     ]
-    if (is_component_build) {
-      if (is_win) {
-        defines += [ "SQLITE_API=__declspec(dllexport)" ]
-      } else {
-        defines += [ "SQLITE_API=__attribute__((visibility(\"default\")))" ]
-      }
-    }
     if (is_chromeos) {
       defines += [
         # Despite obvious warnings about not using this flag in deployment, we
         # are turning off sync in ChromeOS and relying on the underlying
         # journaling filesystem to do error recovery properly. It's much faster.
         "SQLITE_NO_SYNC",
       ]
     }
     if (is_posix) {
       defines += [
@@ skipping 13 matching lines @@
 
     include_dirs = [ "amalgamation" ]
 
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
     configs += [ ":sqlite_warnings" ]
 
     if (is_linux) {
       libs = [ "dl" ]
     } else if (is_mac || is_ios) {
-      libs = [
-        "CoreFoundation.framework",
-        "CoreServices.framework",
-      ]
+      libs = [ "CoreFoundation.framework" ]
     } else if (is_android) {
       defines += [
         "SQLITE_DEFAULT_JOURNAL_SIZE_LIMIT=1048576",
         "SQLITE_DEFAULT_AUTOVACUUM=1",
         "SQLITE_TEMP_STORE=3",
         "SQLITE_ENABLE_FTS3_BACKWARDS",
         "DSQLITE_DEFAULT_FILE_FORMAT=4",
       ]
     }
 
     deps = [
       "//third_party/icu",
     ]
-  }
 
-  config("sqlite_export") {
-    if (is_component_build && is_win) {
-      defines = [ "SQLITE_API=__declspec(dllimport)" ]
-    }
-  }
-
-  # This is used to allow the SQLITE_API definition to be different when
-  # building sqlite3.c than it is when clients include sqlite3.h.
-  group("sqlite") {
-    public_deps = [ ":sqlite_build" ]
-    public_configs = [ ":sqlite_export", ":sqlite_config" ]
+    public_configs = [ ":sqlite_config" ]
   }
 
   if (is_linux) {
     executable("sqlite_shell") {
       sources = [
         "src/src/shell.c",
         "src/src/shell_icu_linux.c",
 
         # Include a dummy c++ file to force linking of libstdc++.
         "build_as_cpp.cc",
@@ skipping 51 matching lines @@
         "//third_party/icu",
       ]
       if (is_clang) {
         # src/ext/icu/icu.c uses assert(!"string") which causes warnings about
         # conversion from string literal to bool.
         configs -= [ "//build/config/clang:extra_warnings" ]
       }
     }
   }
 }