CFI Linux CF: Enable detailed diagnostics using cfi_diag=1.

CFI Linux CF: Enable detailed diagnostics using cfi_diag=1.

BUG=464797
R=inferno@chromium.org
TBR=thakis@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296574

[inferno, 2015-09-05 00:48:20]

lgtm

[pcc1, 2015-09-05 00:48:54]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2015-09-05 00:48:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325803003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325803003/1

[commit-bot: I haz the power, 2015-09-05 00:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-05 00:49:01]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Nico, 2015-09-05 00:57:54]

What's the motivation? Should the default in the gyp file be changed instead?
Requiring an fyi master restart each time you want to toggle this seems kind of
annoying…

[pcc, 2015-09-05 01:02:04]

On 2015/09/05 00:57:54, Nico (offsite Fri Sep 3) wrote:
> What's the motivation? Should the default in the gyp file be changed instead?
> Requiring an fyi master restart each time you want to toggle this seems kind
of
> annoying…

The default in the gyp file is fine, as it matches what we plan to deploy in
official builds. I don't think I'll need to change this on the bot again.

Until we get the CF uploader ported to recipes I guess we'll need to keep doing
master restarts :/

[Nico, 2015-09-05 01:04:12]

lgtm

[pcc1, 2015-09-05 01:05:15]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2015-09-05 01:05:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325803003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325803003/1

[commit-bot: I haz the power, 2015-09-05 01:07:13]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296574