ui/gfx/transform_util_unittest.cc - Issue 1325803002: Apply skew on both axes together rather than sequentially on Compositor thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/transform_util_unittest.cc

Issue 1325803002: Apply skew on both axes together rather than sequentially on Compositor thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test for skewY Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/transform_util_unittest.cc

diff --git a/ui/gfx/transform_util_unittest.cc b/ui/gfx/transform_util_unittest.cc

index 02bf46a4a8c6ffbea2b7e8115ff4c9272d4e34c9..ce5af13bbe7670463e68d47ba6bab9de4e8a21fb 100644

--- a/ui/gfx/transform_util_unittest.cc

+++ b/ui/gfx/transform_util_unittest.cc

@@ -170,7 +170,7 @@ TEST(TransformUtilTest, NoSnapSkewedCompositeTransform) {

SkDoubleToMScalar(2.0));

transform.Translate3d(SkDoubleToMScalar(30.5), SkDoubleToMScalar(20.0),

SkDoubleToMScalar(10.1));

- transform.SkewX(20.0);

+ transform.Skew(20.0, 0.0);

Rect viewport(1920, 1200);

bool snapped = SnapTransform(&result, transform, viewport);

EXPECT_FALSE(snapped) << "Skewed viewport should not snap.";

« no previous file with comments | « ui/gfx/transform_unittest.cc ('k') | no next file » | no next file with comments »