cc/animation/transform_operations.cc - Issue 1325803002: Apply skew on both axes together rather than sequentially on Compositor thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/transform_operations.cc

Issue 1325803002: Apply skew on both axes together rather than sequentially on Compositor thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test for skewY Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/animation/transform_operations.cc

diff --git a/cc/animation/transform_operations.cc b/cc/animation/transform_operations.cc

index fb1c17d517598e3c23af197d72996558d02e70a9..29a3d90626b5139245c75e6e5b5408e744bdf97f 100644

--- a/cc/animation/transform_operations.cc

+++ b/cc/animation/transform_operations.cc

@@ -224,8 +224,7 @@ void TransformOperations::AppendScale(SkMScalar x, SkMScalar y, SkMScalar z) {

void TransformOperations::AppendSkew(SkMScalar x, SkMScalar y) {

TransformOperation to_add;

- to_add.matrix.SkewX(x);

- to_add.matrix.SkewY(y);

+ to_add.matrix.Skew(x, y);

to_add.type = TransformOperation::TRANSFORM_OPERATION_SKEW;

to_add.skew.x = x;

to_add.skew.y = y;

« no previous file with comments | « cc/animation/transform_operation.cc ('k') | cc/animation/transform_operations_unittest.cc » ('j') | no next file with comments »