Changed CSSPropertyObjectPosition to use legacy interpolation

Changed CSSPropertyObjectPosition to use legacy interpolation

Changed CSSPropertyObjectPosition back to use legacy interpolation, as
the new interpolation doesn't support interpolating between pairs and
pairs-of-pairs.

Suspected CL:
https://chromium.googlesource.com/chromium/blink/+/a3be631e4554bcf918ef17f31112a3f7d93f376d.

BUG=526738
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201528

[sashab, 2015-09-01 03:11:46]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org, timloh@chromium.org

[alancutter (OOO until 2018), 2015-09-01 03:38:45]

https://codereview.chromium.org/1325783004/diff/1/LayoutTests/animations/inte...
File LayoutTests/animations/interpolation/object-position-interpolation.html
(right):

https://codereview.chromium.org/1325783004/diff/1/LayoutTests/animations/inte...
LayoutTests/animations/interpolation/object-position-interpolation.html:133: //
Bug 526738: Check that an element can be animated from a pair to a pair of pairs
No need to add comment, git blame will be sufficient here.

https://codereview.chromium.org/1325783004/diff/1/LayoutTests/animations/inte...
LayoutTests/animations/interpolation/object-position-interpolation.html:141: ]);
0 and 1 don't really test interpolation at all, we should test the fractions
that the other assertInterpolations test as well. You can set "rebase: true" in
interpolation-test.js for convenience in getting the expected value code.

https://codereview.chromium.org/1325783004/diff/1/Source/core/animation/Strin...
File Source/core/animation/StringKeyframe.cpp (right):

https://codereview.chromium.org/1325783004/diff/1/Source/core/animation/Strin...
Source/core/animation/StringKeyframe.cpp:380: range = RangeNonNegative;
We can use RangeNonNegative directly here.

[dstockwell, 2015-09-01 03:40:42]

Could you please reference the patch which introduced the problem, I can't see
the bug.

[sashab, 2015-09-01 04:49:03]

https://codereview.chromium.org/1325783004/diff/1/LayoutTests/animations/inte...
File LayoutTests/animations/interpolation/object-position-interpolation.html
(right):

https://codereview.chromium.org/1325783004/diff/1/LayoutTests/animations/inte...
LayoutTests/animations/interpolation/object-position-interpolation.html:133: //
Bug 526738: Check that an element can be animated from a pair to a pair of pairs
On 2015/09/01 03:38:45, alancutter wrote:
> No need to add comment, git blame will be sufficient here.

Done.

https://codereview.chromium.org/1325783004/diff/1/LayoutTests/animations/inte...
LayoutTests/animations/interpolation/object-position-interpolation.html:141: ]);
On 2015/09/01 03:38:45, alancutter wrote:
> 0 and 1 don't really test interpolation at all, we should test the fractions
> that the other assertInterpolations test as well. You can set "rebase: true"
in
> interpolation-test.js for convenience in getting the expected value code.

Done.

https://codereview.chromium.org/1325783004/diff/1/Source/core/animation/Strin...
File Source/core/animation/StringKeyframe.cpp (right):

https://codereview.chromium.org/1325783004/diff/1/Source/core/animation/Strin...
Source/core/animation/StringKeyframe.cpp:380: range = RangeNonNegative;
On 2015/09/01 03:38:45, alancutter wrote:
> We can use RangeNonNegative directly here.

Done.

[alancutter (OOO until 2018), 2015-09-01 05:25:40]

lgtm

[sashab, 2015-09-01 05:28:33]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2015-09-01 05:28:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325783004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325783004/20001

[commit-bot: I haz the power, 2015-09-01 07:24:04]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201528