Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1325703002: Mandoline: Fix OOPIF high DPI sizing. (Closed)

Created:
5 years, 3 months ago by Fady Samuel
Modified:
5 years, 3 months ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline: Fix OOPIF high DPI sizing. This CL plumbs device scale factor through mojo::CompositorFrame messages and uses it to set the bounds of the View being updated. BUG=526265 Committed: https://crrev.com/d4f1feb7c65bb7a4406b6183664da081795cb2db Cr-Commit-Position: refs/heads/master@{#346484}

Patch Set 1 #

Patch Set 2 : Remove unnecessary BrowserWindow Change #

Patch Set 3 : Hopefully fixed on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -13 lines) Patch
M components/view_manager/connection_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/view_manager/connection_manager.cc View 3 chunks +16 lines, -4 lines 0 comments Download
M components/view_manager/public/interfaces/compositor_frame.mojom View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/converters/surfaces/custom_surface_converter.h View 1 chunk +6 lines, -3 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.h View 1 2 3 chunks +15 lines, -0 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 2 9 chunks +32 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Fady Samuel
+sky@ for OWNER review +rjkroege@ FYI
5 years, 3 months ago (2015-08-31 19:10:59 UTC) #2
sky
LGTM
5 years, 3 months ago (2015-08-31 19:59:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325703002/20001
5 years, 3 months ago (2015-08-31 20:33:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/35041)
5 years, 3 months ago (2015-08-31 20:56:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325703002/40001
5 years, 3 months ago (2015-08-31 21:35:36 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-31 22:05:08 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 22:06:11 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d4f1feb7c65bb7a4406b6183664da081795cb2db
Cr-Commit-Position: refs/heads/master@{#346484}

Powered by Google App Engine
This is Rietveld 408576698