components/metrics/call_stack_profile_metrics_provider.h - Issue 1325653003: Type change in StackSamplingProfiler from void* to uintptr_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/call_stack_profile_metrics_provider.h

Issue 1325653003: Type change in StackSamplingProfiler from void* to uintptr_t. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@UMA2_refactor

Patch Set: Moved IPC structures into content/common and merged with dependent CL. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/profiler/stack_sampling_profiler.cc ('k') | components/metrics/call_stack_profile_metrics_provider_unittest.cc » ('j') | components/metrics/call_stack_profile_metrics_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/call_stack_profile_metrics_provider.h

diff --git a/components/metrics/call_stack_profile_metrics_provider.h b/components/metrics/call_stack_profile_metrics_provider.h

index d368c99c4ace94222b512b746d79bb3b49db290c..b5e72edf2774402476a63c6f5a29ed0a5267a1c3 100644

--- a/components/metrics/call_stack_profile_metrics_provider.h

+++ b/components/metrics/call_stack_profile_metrics_provider.h

@@ -18,11 +18,13 @@ class ChromeUserMetricsExtension;

class CallStackProfileMetricsProvider : public MetricsProvider {

public:

// The event that triggered the profile collection.

+ // Keep this enum in sync with content/common/profiled_stack_state.h

Mike Wittman 2015/09/03 16:58:04 nit: we generally don't use imperative comments in

sydli 2015/09/03 17:18:13 Done.

enum Trigger {

UNKNOWN,

PROCESS_STARTUP,

JANKY_TASK,

- THREAD_HUNG

+ THREAD_HUNG,

+ TRIGGER_LAST = THREAD_HUNG

};

// Parameters to pass back to the metrics provider.