Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: base/profiler/native_stack_sampler_win.cc

Issue 1325653003: Type change in StackSamplingProfiler from void* to uintptr_t. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@UMA2_refactor
Patch Set: Addressed wittman's comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/profiler/stack_sampling_profiler.h » ('j') | content/common/profiled_stack_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/profiler/native_stack_sampler_win.cc
diff --git a/base/profiler/native_stack_sampler_win.cc b/base/profiler/native_stack_sampler_win.cc
index a39502d378ac87e4876df5d28b640bc428ff6514..d9b8aa7e47a1a97832bf55b1c6b1bf5eea134550 100644
--- a/base/profiler/native_stack_sampler_win.cc
+++ b/base/profiler/native_stack_sampler_win.cc
@@ -266,7 +266,7 @@ bool NativeStackSamplerWin::GetModuleForHandle(
module->filename = base::FilePath(module_name);
- module->base_address = reinterpret_cast<const void*>(module_handle);
+ module->base_address = reinterpret_cast<uintptr_t>(module_handle);
module->id = GetBuildIDForModule(module_handle);
if (module->id.empty())
@@ -305,7 +305,7 @@ void NativeStackSamplerWin::CopyToSample(
for (int i = 0; i < stack_depth; ++i) {
sample->push_back(StackSamplingProfiler::Frame(
- instruction_pointers[i],
+ reintrepret_cast<uintptr_t>(instruction_pointers[i]),
robliao 2015/09/03 21:46:45 reint[re]pret -> reinterpret
sydli 2015/09/09 17:08:45 Done.
GetModuleIndex(module_handles[i], module)));
}
}
« no previous file with comments | « no previous file | base/profiler/stack_sampling_profiler.h » ('j') | content/common/profiled_stack_state.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698