Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 132563006: CSP 1.1: <meta> delivery should be ignored outside <head>. (Closed)

Created:
6 years, 10 months ago by Mike West
Modified:
6 years, 10 months ago
CC:
blink-reviews, kenneth.christiansen, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, mkwst+watchlist_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Feedback. #

Patch Set 3 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
A + LayoutTests/http/tests/security/contentSecurityPolicy/1.1/meta-outside-head.html View 1 chunk +5 lines, -2 lines 0 comments Download
A LayoutTests/http/tests/security/contentSecurityPolicy/1.1/meta-outside-head-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 2 chunks +14 lines, -9 lines 0 comments Download
M Source/core/frame/ContentSecurityPolicy.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/ContentSecurityPolicy.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMetaElement-in.cpp View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Mike West
Moar CSP 1.1. -mike
6 years, 10 months ago (2014-02-06 11:16:28 UTC) #1
kenneth.r.christiansen
lgtm https://codereview.chromium.org/132563006/diff/1/Source/core/dom/Document.h File Source/core/dom/Document.h (right): https://codereview.chromium.org/132563006/diff/1/Source/core/dom/Document.h#newcode730 Source/core/dom/Document.h:730: void processHttpEquiv(const AtomicString& equiv, const AtomicString& content, bool ...
6 years, 10 months ago (2014-02-06 12:54:44 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-06 14:48:57 UTC) #3
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-07 11:17:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/132563006/90001
6 years, 10 months ago (2014-02-07 11:17:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 12:38:40 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=26333
6 years, 10 months ago (2014-02-07 12:38:41 UTC) #7
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-14 07:53:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/132563006/250001
6 years, 10 months ago (2014-02-14 07:54:05 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 10:42:21 UTC) #10
Message was sent while issue was closed.
Change committed as 167171

Powered by Google App Engine
This is Rietveld 408576698