Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 132563005: Initialize VTTCue::m_displaySize to undefinedSize (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Initialize VTTCue::m_displaySize to undefinedSize It was not initialized at all, and while the current code appears to always write it before reading it, it's a bug waiting to happen. (It would be nice to not have render state in VTTCue at all.) BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/html/track/vtt/VTTCue.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-27 10:19:06 UTC) #1
adamk
lgtm
6 years, 10 months ago (2014-01-28 23:51:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/132563005/1
6 years, 10 months ago (2014-01-29 02:03:38 UTC) #3
commit-bot: I haz the power
Change committed as 165987
6 years, 10 months ago (2014-01-29 02:13:26 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 02:15:28 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698