Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1325623002: New SELECT Popup: Compare OPTION style with the parent OPTGROUP. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

New SELECT Popup: Compare OPTION style with the parent OPTGROUP. When we serialize style data for an OPTION, we had a bug that the OPTION style was compared to the SELECT style even though the OPTION is in an OPTGROUP. We should compare with the OPTGROUP style. BUG=526077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201474

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -31 lines) Patch
A LayoutTests/fast/forms/select/popup-menu-nested-style.html View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/select/popup-menu-nested-style-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/platform/mac/fast/forms/select/popup-menu-nested-style-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/PopupMenuImpl.cpp View 7 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tkent
Keishi, would you review this please?
5 years, 3 months ago (2015-08-31 06:28:40 UTC) #2
keishi
LGTM
5 years, 3 months ago (2015-08-31 06:44:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325623002/20001
5 years, 3 months ago (2015-08-31 07:07:06 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 08:40:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201474

Powered by Google App Engine
This is Rietveld 408576698