Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1325603003: Add breakpad fetch recipe. (Closed)

Created:
5 years, 3 months ago by Vadim Sh.
Modified:
5 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/remotes/origin/master
Visibility:
Public.

Description

Add breakpad fetch recipe. $ mkdir breakpad && cd breakpad $ fetch breakpad $ cd src/ $ ./configure && make R=iannucci@chromium.org BUG=502355 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296495

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
A + recipes/breakpad.py View 4 chunks +9 lines, -10 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Vadim Sh.
5 years, 3 months ago (2015-08-31 19:03:51 UTC) #1
iannucci
lgtm
5 years, 3 months ago (2015-08-31 19:05:14 UTC) #2
iannucci
https://codereview.chromium.org/1325603003/diff/1/recipes/breakpad.py File recipes/breakpad.py (right): https://codereview.chromium.org/1325603003/diff/1/recipes/breakpad.py#newcode17 recipes/breakpad.py:17: 'name': 'src', "src" ugh, I hate gclient :(
5 years, 3 months ago (2015-08-31 19:05:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325603003/1
5 years, 3 months ago (2015-08-31 19:08:27 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 19:10:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296495

Powered by Google App Engine
This is Rietveld 408576698