Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1325593004: Allow mojo_debug gdb attach to search symbols in multiple directories. (Closed)

Created:
5 years, 3 months ago by etiennej
Modified:
5 years, 3 months ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Allow mojo_debug gdb attach to search symbols in multiple directories. This fixes domokit/devtools#38. R=qsr@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1e331d28863d4b6a4084c22dd2447c5718c40462

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M mojo/devtools/common/android_gdb/session.py View 1 3 chunks +14 lines, -12 lines 0 comments Download
M mojo/devtools/common/mojo_debug View 1 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
etiennej
5 years, 3 months ago (2015-09-03 10:00:21 UTC) #4
qsr (NOT THE RIGHT qsr)
https://codereview.chromium.org/1325593004/diff/40001/mojo/devtools/common/android_gdb/session.py File mojo/devtools/common/android_gdb/session.py (right): https://codereview.chromium.org/1325593004/diff/40001/mojo/devtools/common/android_gdb/session.py#newcode78 mojo/devtools/common/android_gdb/session.py:78: logging.fatal("Please pass a valid build directory") The message might ...
5 years, 3 months ago (2015-09-03 10:34:04 UTC) #6
etiennej
https://codereview.chromium.org/1325593004/diff/40001/mojo/devtools/common/android_gdb/session.py File mojo/devtools/common/android_gdb/session.py (right): https://codereview.chromium.org/1325593004/diff/40001/mojo/devtools/common/android_gdb/session.py#newcode78 mojo/devtools/common/android_gdb/session.py:78: logging.fatal("Please pass a valid build directory") On 2015/09/03 10:34:04, ...
5 years, 3 months ago (2015-09-03 11:45:44 UTC) #7
qsr (NOT THE RIGHT qsr)
lgtm
5 years, 3 months ago (2015-09-03 11:55:15 UTC) #8
etiennej
5 years, 3 months ago (2015-09-03 11:55:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
1e331d28863d4b6a4084c22dd2447c5718c40462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698