Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: src/object-observe.js

Issue 1325573004: [runtime] Replace many buggy uses of %_CallFunction with %_Call. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address feedback. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/interface-descriptors-mips64.cc ('k') | src/promise.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var $observeEnqueueSpliceRecord; 5 var $observeEnqueueSpliceRecord;
6 var $observeBeginPerformSplice; 6 var $observeBeginPerformSplice;
7 var $observeEndPerformSplice; 7 var $observeEndPerformSplice;
8 8
9 var $observeObjectMethods; 9 var $observeObjectMethods;
10 var $observeArrayMethods; 10 var $observeArrayMethods;
(...skipping 583 matching lines...) Expand 10 before | Expand all | Expand 10 after
594 var performChangeFn = %GetObjectContextNotifierPerformChange(objectInfo); 594 var performChangeFn = %GetObjectContextNotifierPerformChange(objectInfo);
595 performChangeFn(objectInfo, changeType, changeFn); 595 performChangeFn(objectInfo, changeType, changeFn);
596 } 596 }
597 597
598 598
599 function NativeObjectNotifierPerformChange(objectInfo, changeType, changeFn) { 599 function NativeObjectNotifierPerformChange(objectInfo, changeType, changeFn) {
600 ObjectInfoAddPerformingType(objectInfo, changeType); 600 ObjectInfoAddPerformingType(objectInfo, changeType);
601 601
602 var changeRecord; 602 var changeRecord;
603 try { 603 try {
604 changeRecord = %_CallFunction(UNDEFINED, changeFn); 604 changeRecord = changeFn();
605 } finally { 605 } finally {
606 ObjectInfoRemovePerformingType(objectInfo, changeType); 606 ObjectInfoRemovePerformingType(objectInfo, changeType);
607 } 607 }
608 608
609 if (IS_SPEC_OBJECT(changeRecord)) 609 if (IS_SPEC_OBJECT(changeRecord))
610 ObjectInfoEnqueueExternalChangeRecord(objectInfo, changeRecord, changeType); 610 ObjectInfoEnqueueExternalChangeRecord(objectInfo, changeRecord, changeType);
611 } 611 }
612 612
613 613
614 function ObjectGetNotifier(object) { 614 function ObjectGetNotifier(object) {
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 "native_object_get_notifier", NativeObjectGetNotifier, 707 "native_object_get_notifier", NativeObjectGetNotifier,
708 "native_object_notifier_perform_change", NativeObjectNotifierPerformChange, 708 "native_object_notifier_perform_change", NativeObjectNotifierPerformChange,
709 "native_object_observe", NativeObjectObserve, 709 "native_object_observe", NativeObjectObserve,
710 "observers_begin_perform_splice", BeginPerformSplice, 710 "observers_begin_perform_splice", BeginPerformSplice,
711 "observers_end_perform_splice", EndPerformSplice, 711 "observers_end_perform_splice", EndPerformSplice,
712 "observers_enqueue_splice", EnqueueSpliceRecord, 712 "observers_enqueue_splice", EnqueueSpliceRecord,
713 "observers_notify_change", NotifyChange, 713 "observers_notify_change", NotifyChange,
714 ]); 714 ]);
715 715
716 }) 716 })
OLDNEW
« no previous file with comments | « src/mips64/interface-descriptors-mips64.cc ('k') | src/promise.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698