[runtime] Replace many buggy uses of %_CallFunction with %_Call.

src/collection.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var $getHash;
 var $getExistingHash;
 
 (function(global, utils) {
 "use strict";
 
@@ skipping 121 matching lines @@
 
   %_SetInitialize(this);
 
   if (!IS_NULL_OR_UNDEFINED(iterable)) {
     var adder = this.add;
     if (!IS_CALLABLE(adder)) {
       throw MakeTypeError(kPropertyNotFunction, 'add', this);
     }
 
     for (var value of iterable) {
-      %_CallFunction(this, value, adder);
+      %_Call(adder, this, value);
     }
   }
 }
 
 
 function SetAdd(key) {
   if (!IS_SET(this)) {
     throw MakeTypeError(kIncompatibleMethodReceiver, 'Set.prototype.add', this);
   }
   // Normalize -0 to +0 as required by the spec.
@@ skipping 86 matching lines @@
 }
 
 
 function SetForEach(f, receiver) {
   if (!IS_SET(this)) {
     throw MakeTypeError(kIncompatibleMethodReceiver,
                         'Set.prototype.forEach', this);
   }
 
   if (!IS_CALLABLE(f)) throw MakeTypeError(kCalledNonCallable, f);
-  var needs_wrapper = false;
-  if (IS_NULL(receiver)) {
-    if (%IsSloppyModeFunction(f)) receiver = UNDEFINED;
-  } else if (!IS_UNDEFINED(receiver)) {
-    needs_wrapper = SHOULD_CREATE_WRAPPER(f, receiver);
-  }
 
   var iterator = new SetIterator(this, ITERATOR_KIND_VALUES);
   var key;
   var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
   var value_array = [UNDEFINED];
   while (%SetIteratorNext(iterator, value_array)) {
     if (stepping) %DebugPrepareStepInIfStepping(f);
     key = value_array[0];
-    var new_receiver = needs_wrapper ? TO_OBJECT(receiver) : receiver;
-    %_CallFunction(new_receiver, key, key, this, f);
+    %_Call(f, receiver, key, key, this);
   }
 }
 
 // -------------------------------------------------------------------
 
 %SetCode(GlobalSet, SetConstructor);
 %FunctionSetLength(GlobalSet, 0);
 %FunctionSetPrototype(GlobalSet, new GlobalObject());
 %AddNamedProperty(GlobalSet.prototype, "constructor", GlobalSet, DONT_ENUM);
 %AddNamedProperty(GlobalSet.prototype, toStringTagSymbol, "Set",
@@ skipping 25 matching lines @@
   if (!IS_NULL_OR_UNDEFINED(iterable)) {
     var adder = this.set;
     if (!IS_CALLABLE(adder)) {
       throw MakeTypeError(kPropertyNotFunction, 'set', this);
     }
 
     for (var nextItem of iterable) {
       if (!IS_SPEC_OBJECT(nextItem)) {
         throw MakeTypeError(kIteratorValueNotAnObject, nextItem);
       }
-      %_CallFunction(this, nextItem[0], nextItem[1], adder);
+      %_Call(adder, this, nextItem[0], nextItem[1]);
     }
   }
 }
 
 
 function MapGet(key) {
   if (!IS_MAP(this)) {
     throw MakeTypeError(kIncompatibleMethodReceiver,
                         'Map.prototype.get', this);
   }
@@ skipping 109 matching lines @@
 }
 
 
 function MapForEach(f, receiver) {
   if (!IS_MAP(this)) {
     throw MakeTypeError(kIncompatibleMethodReceiver,
                         'Map.prototype.forEach', this);
   }
 
   if (!IS_CALLABLE(f)) throw MakeTypeError(kCalledNonCallable, f);
-  var needs_wrapper = false;
-  if (IS_NULL(receiver)) {
-    if (%IsSloppyModeFunction(f)) receiver = UNDEFINED;
-  } else if (!IS_UNDEFINED(receiver)) {
-    needs_wrapper = SHOULD_CREATE_WRAPPER(f, receiver);
-  }
 
   var iterator = new MapIterator(this, ITERATOR_KIND_ENTRIES);
   var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
   var value_array = [UNDEFINED, UNDEFINED];
   while (%MapIteratorNext(iterator, value_array)) {
     if (stepping) %DebugPrepareStepInIfStepping(f);
-    var new_receiver = needs_wrapper ? TO_OBJECT(receiver) : receiver;
-    %_CallFunction(new_receiver, value_array[1], value_array[0], this, f);
+    %_Call(f, receiver, value_array[1], value_array[0], this);
   }
 }
 
 // -------------------------------------------------------------------
 
 %SetCode(GlobalMap, MapConstructor);
 %FunctionSetLength(GlobalMap, 0);
 %FunctionSetPrototype(GlobalMap, new GlobalObject());
 %AddNamedProperty(GlobalMap.prototype, "constructor", GlobalMap, DONT_ENUM);
 %AddNamedProperty(
@@ skipping 15 matching lines @@
 // Expose to the global scope.
 $getHash = GetHash;
 $getExistingHash = GetExistingHash;
 
 function MapFromArray(array) {
   var map = new GlobalMap;
   var length = array.length;
   for (var i = 0; i < length; i += 2) {
     var key = array[i];
     var value = array[i + 1];
-    %_CallFunction(map, key, value, MapSet);
+    %_Call(MapSet, map, key, value);
   }
   return map;
 };
 
 function SetFromArray(array) {
   var set = new GlobalSet;
   var length = array.length;
   for (var i = 0; i < length; ++i) {
-    %_CallFunction(set, array[i], SetAdd);
+    %_Call(SetAdd, set, array[i]);
   }
   return set;
 };
 
 // -----------------------------------------------------------------------
 // Exports
 
 %InstallToContext([
   "map_get", MapGet,
   "map_set", MapSet,
   "map_has", MapHas,
   "map_delete", MapDelete,
   "set_add", SetAdd,
   "set_has", SetHas,
   "set_delete", SetDelete,
   "map_from_array", MapFromArray,
   "set_from_array",SetFromArray,
 ]);
 
 })