Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2057)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 1325563002: Avoid style clobbering in setCompositionFromExistingText. (2nd land) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Release Range on document detach and remove selectionStart/End Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 1d3f446d1e4acd57d7eb6a03c54d22d081d766d6..0d05c3324a85edc76516d57dd10711115720c916 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -2570,20 +2570,6 @@ bool WebViewImpl::isSelectionAnchorFirst() const
return toLocalFrame(frame)->selection().selection().isBaseFirst();
}
-WebVector<WebCompositionUnderline> WebViewImpl::compositionUnderlines() const
-{
- const LocalFrame* focused = toLocalFrame(focusedCoreFrame());
- if (!focused)
- return WebVector<WebCompositionUnderline>();
- const Vector<CompositionUnderline>& underlines = focused->inputMethodController().customCompositionUnderlines();
- WebVector<WebCompositionUnderline> results(underlines.size());
- for (size_t index = 0; index < underlines.size(); ++index) {
- CompositionUnderline underline = underlines[index];
- results[index] = WebCompositionUnderline(underline.startOffset, underline.endOffset, static_cast<WebColor>(underline.color.rgb()), underline.thick, static_cast<WebColor>(underline.backgroundColor.rgb()));
- }
- return results;
-}
-
WebColor WebViewImpl::backgroundColor() const
{
if (isTransparent())
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698