Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1325513002: [sqlite] Respect the gyp and gn component switch. (Closed)

Created:
5 years, 3 months ago by Scott Hess - ex-Googler
Modified:
5 years, 3 months ago
Reviewers:
michaeln, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sqlite] Respect the gyp and gn component switch. SQLITE_API is the existing mechanism SQLite provides, and is used in preference to inventing a new SQLITE_EXPORT symbol (like sql/sql_export.h and other examples). CoreServices.framework is necessary on OSX because of the Time Machine patch. Remove sql/proxy.{h,cc}, which was necessary to work around SQLite linking statically into both component shlibs and unit test executables. [Relanding https://codereview.chromium.org/1322463002/ ] BUG=489444 TBR=michaeln@chromium.org, thakis@chromium.org Committed: https://crrev.com/02ce712af589a5b722ebbf5c2fffb3e0d4849963 Cr-Commit-Position: refs/heads/master@{#346212}

Patch Set 1 #

Patch Set 2 : Fix dumb BUILD.gn osx/win breakage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -81 lines) Patch
M sql/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sql/connection_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
D sql/proxy.h View 1 chunk +0 lines, -39 lines 0 comments Download
D sql/proxy.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M sql/sql.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 3 chunks +15 lines, -2 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Scott Hess - ex-Googler
Fix dumb BUILD.gn osx/win breakage.
5 years, 3 months ago (2015-08-28 18:12:51 UTC) #1
Scott Hess - ex-Googler
Relanding https://codereview.chromium.org/1322463002/ (which Michael lgtm'ed) with patch 1 from https://codereview.chromium.org/1313013008/ (which Nico lgtm'ed). I'll probably ...
5 years, 3 months ago (2015-08-28 18:17:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325513002/20001
5 years, 3 months ago (2015-08-28 19:15:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-28 19:39:29 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/02ce712af589a5b722ebbf5c2fffb3e0d4849963 Cr-Commit-Position: refs/heads/master@{#346212}
5 years, 3 months ago (2015-08-28 19:40:15 UTC) #7
Scott Hess - ex-Googler
5 years, 3 months ago (2015-08-28 19:52:59 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1307363007/ by shess@chromium.org.

The reason for reverting is: ARRGH!  win8_chromium_gn_dgb is still broken..

Powered by Google App Engine
This is Rietveld 408576698