Properly fix DirWatcherTest.SubDir on Vista.

Properly fix DirWatcherTest.SubDir on Vista.

BUG=5072

[please use my chromium address, 2008-12-08 20:57:26]

Tested compile & base_unittests on XP. I'm not sure it fixes issue on Vista, but
it should (the behavior should be consistent now).

[Mark Mentovai, 2008-12-08 21:02:07]

Defer to M-A on Windowsisms, but the code looks good - this will need to take a
spin on Vista

http://codereview.chromium.org/13255/diff/1/4
File base/directory_watcher.h (right):

http://codereview.chromium.org/13255/diff/1/4#newcode19
Line 19: // is created, deleted or rename in the directory. Does not watch
renamed

http://codereview.chromium.org/13255/diff/1/2
File base/directory_watcher_win.cc (right):

http://codereview.chromium.org/13255/diff/1/2#newcode51
Line 51: FILE_NOTIFY_CHANGE_DIR_NAME |
Add four more spaces of indent to these three lines so that they look like
constants being ORed into the same argument and not so much like additional
arguments.

[please use my chromium address, 2008-12-08 21:22:52]

http://codereview.chromium.org/13255/diff/1/4
File base/directory_watcher.h (right):

http://codereview.chromium.org/13255/diff/1/4#newcode19
Line 19: // is created, deleted or rename in the directory. Does not watch
On 2008/12/08 21:02:07, Mark Mentovai wrote:
> renamed

Done.

http://codereview.chromium.org/13255/diff/1/2
File base/directory_watcher_win.cc (right):

http://codereview.chromium.org/13255/diff/1/2#newcode51
Line 51: FILE_NOTIFY_CHANGE_DIR_NAME |
On 2008/12/08 21:02:07, Mark Mentovai wrote:
> Add four more spaces of indent to these three lines so that they look like
> constants being ORed into the same argument and not so much like additional
> arguments.

Done.

[M-A Ruel, 2008-12-09 00:53:53]

lgtm

[M-A Ruel, 2008-12-09 17:16:29]

http://codereview.chromium.org/13255/diff/206/208
File base/directory_watcher_unittest.cc (right):

http://codereview.chromium.org/13255/diff/206/208#newcode41
Line 41: ++directory_mods_;
Add this:
  EXPECT_EQ(path.value(), test_dir_.value());

http://codereview.chromium.org/13255/diff/206/208#newcode149
Line 149: 
The test was passing on Windows XP because of a timing issue. For an unknown
reason, it's very long for the second notification to come in (~1 sec). So you
need to add the following line:
  LoopUntilModsEqual(2);

I don't know how this relates to the other platforms. Maybe some work needs to
be done on the DirectoryWatcher class.

http://codereview.chromium.org/13255/diff/206/208#newcode156
Line 156: // We shouldn't have been notified (except for creating SubDir),
fix comment, that's not what is happening.

http://codereview.chromium.org/13255/diff/206/208#newcode158
Line 158: ASSERT_EQ(1, directory_mods_);
  ASSERT_EQ(2, directory_mods_);