Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1325493002: NOT FOR LANDING Introduce and use WebMediaSession (Closed)

Created:
5 years, 3 months ago by davve
Modified:
4 years, 9 months ago
Reviewers:
CC:
blink-reviews, tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, philipj_slow, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, kinuko+watch, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

NOT FOR LANDING Introduce and use WebMediaSession Chromium CL: https://codereview.chromium.org/1308983005/ BUG=497735

Patch Set 1 #

Patch Set 2 : Add promise support #

Patch Set 3 : Fix test and use CallbackPromise adapter #

Patch Set 4 : Reject activate() promise with TypeError #

Patch Set 5 : Add missing files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -16 lines) Patch
M Source/bindings/core/v8/CallbackPromiseAdapter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/modules/mediasession/HTMLMediaElementMediaSession.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasession/HTMLMediaElementMediaSession.cpp View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M Source/modules/mediasession/HTMLMediaElementMediaSession.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasession/MediaSession.h View 1 2 1 chunk +20 lines, -5 lines 0 comments Download
M Source/modules/mediasession/MediaSession.cpp View 1 2 3 1 chunk +37 lines, -4 lines 0 comments Download
M Source/modules/mediasession/MediaSession.idl View 1 1 chunk +3 lines, -2 lines 0 comments Download
A Source/modules/mediasession/MediaSessionError.h View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A Source/modules/mediasession/MediaSessionError.cpp View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A Source/modules/mediasession/MediaSessionTest.cpp View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 3 chunks +16 lines, -1 line 0 comments Download
M public/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A public/platform/modules/mediasession/WebMediaSession.h View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M public/web/WebFrameClient.h View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 1 (1 generated)
davve
4 years, 9 months ago (2016-03-24 09:47:07 UTC) #1 
Description was changed from

==========
NOT FOR LANDING Introduce and use WebMediaSession

Chromium CL: https://codereview.chromium.org/1308983005/

BUG=497735
==========

to

==========
NOT FOR LANDING Introduce and use WebMediaSession

Chromium CL: https://codereview.chromium.org/1308983005/

BUG=497735
==========

Powered by Google App Engine
This is Rietveld 408576698