Adding ElementsAccessor::Pop

src/elements.cc

Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index d17efafcebb2c6c88e585381ffda311db20d63bc..b5c4cf18ce960b27139742d338b59bf1614a0723 100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -639,6 +639,21 @@ class ElementsAccessorBase : public ElementsAccessor {
     return Handle<JSArray>();
   }
 
+  virtual Handle<Object> Pop(Handle<JSArray> receiver,
+                             Handle<FixedArrayBase> backing_store) final {
+    return ElementsAccessorSubclass::PopImpl(receiver, backing_store);
+  }
+
+  static Handle<Object> PopImpl(Handle<JSArray> receiver,

[Igor Sheludko, 2015/08/31 14:08:03]

I think FastElementsAccessor is a better place for this implementation. And
ElementsAccessorBase::PopImpl should be unreachable.

[Camillo Bruni, 2015/08/31 14:41:35]

moved PopImpl down to FastElementsAccessor

+                                Handle<FixedArrayBase> backing_store) {
+    uint32_t new_length =
+        static_cast<uint32_t>(Smi::cast(receiver->length())->value()) - 1;
+    Handle<Object> result =
+        ElementsAccessorSubclass::GetImpl(backing_store, new_length);
+    ElementsAccessorSubclass::SetLengthImpl(receiver, new_length,
+                                            backing_store);
+    return result;
+  }
 
   virtual void SetLength(Handle<JSArray> array, uint32_t length) final {
     ElementsAccessorSubclass::SetLengthImpl(array, length,