Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1325453005: [turbofan] Break dependency on RegisterAllocationData from Merge. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Break dependency on RegisterAllocationData from Merge. Found this while working on the unit tests for split/splinter/merge. The dependency is unnecessary and hinders testability. BUG= Committed: https://crrev.com/2f27911bf53949a498f7628a6ee46bb57e323f09 Cr-Commit-Position: refs/heads/master@{#30465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/compiler/live-range-separator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/register-allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/register-allocator.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-08-31 09:48:33 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-08-31 09:53:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325453005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325453005/1
5 years, 3 months ago (2015-08-31 09:53:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 10:45:17 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 10:45:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f27911bf53949a498f7628a6ee46bb57e323f09
Cr-Commit-Position: refs/heads/master@{#30465}

Powered by Google App Engine
This is Rietveld 408576698