[Sync] rename USS processor / worker interfaces

ModelTypeSyncProxy -> ModelTypeProcessor
ModelTypeSyncWorker -> CommitQueue

BUG=525830
Committed: https://crrev.com/5b0ee7313734fb1714457b19e24b07db88de9f79
Cr-Commit-Position: refs/heads/master@{#346521}

[Gang Wu, 2015-08-28 21:10:40]

Patchset #1 (id:1) has been deleted

[Gang Wu, 2015-08-28 21:40:01]

Patchset #1 (id:20001) has been deleted

[Gang Wu, 2015-08-28 22:49:02]

Patchset #1 (id:40001) has been deleted

[Gang Wu, 2015-08-28 23:22:41]

gangwu@chromium.org changed reviewers:
+ stanisc@chromium.org

[Gang Wu, 2015-08-28 23:22:42]

Please take a look.

[stanisc, 2015-08-29 00:10:01]

https://codereview.chromium.org/1325453003/diff/60001/chrome/browser/sync/pro...
File chrome/browser/sync/profile_sync_service.h (right):

https://codereview.chromium.org/1325453003/diff/60001/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_service.h:363: const
base::WeakPtr<syncer_v2::ModelTypeProcessorImpl>& proxy);
This change was supposed to be limited to interfaces only so that we could work
on the remaining changes in parallel. But since you've already made all the
remaining changes, let's keep them.

This particular part of code would need to be changed to use ModelTypeProcessor
interface. Since you are already touching it, we better do it right to avoid yet
another change.

https://codereview.chromium.org/1325453003/diff/60001/sync/engine/commit_queu...
File sync/engine/commit_queue_impl.h (right):

https://codereview.chromium.org/1325453003/diff/60001/sync/engine/commit_queu...
sync/engine/commit_queue_impl.h:52: class SYNC_EXPORT CommitQueueImpl : public
syncer::UpdateHandler,
Not the right name.
This is ModelTypeWorker since it implements other interfaces in addition to
CommitQueue.

https://codereview.chromium.org/1325453003/diff/60001/sync/sync.gyp
File sync/sync.gyp (right):

https://codereview.chromium.org/1325453003/diff/60001/sync/sync.gyp#newcode114
sync/sync.gyp:114: 'engine/commit_queue_impl.cc',
There shouldn't be CommitQueueImpl. This is supposed to be called
ModelTypeWorker because it implements other interfaces in addition to
CommitQueue.

[Gang Wu, 2015-08-29 05:03:03]

updated

https://codereview.chromium.org/1325453003/diff/60001/chrome/browser/sync/pro...
File chrome/browser/sync/profile_sync_service.h (right):

https://codereview.chromium.org/1325453003/diff/60001/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_service.h:363: const
base::WeakPtr<syncer_v2::ModelTypeProcessorImpl>& proxy);
On 2015/08/29 00:10:00, stanisc wrote:
> This change was supposed to be limited to interfaces only so that we could
work
> on the remaining changes in parallel. But since you've already made all the
> remaining changes, let's keep them.
> 
> This particular part of code would need to be changed to use
ModelTypeProcessor
> interface. Since you are already touching it, we better do it right to avoid
yet
> another change.

Done.

https://codereview.chromium.org/1325453003/diff/60001/sync/engine/commit_queu...
File sync/engine/commit_queue_impl.h (right):

https://codereview.chromium.org/1325453003/diff/60001/sync/engine/commit_queu...
sync/engine/commit_queue_impl.h:52: class SYNC_EXPORT CommitQueueImpl : public
syncer::UpdateHandler,
On 2015/08/29 00:10:00, stanisc wrote:
> Not the right name.
> This is ModelTypeWorker since it implements other interfaces in addition to
> CommitQueue.

Done.

https://codereview.chromium.org/1325453003/diff/60001/sync/sync.gyp
File sync/sync.gyp (right):

https://codereview.chromium.org/1325453003/diff/60001/sync/sync.gyp#newcode114
sync/sync.gyp:114: 'engine/commit_queue_impl.cc',
On 2015/08/29 00:10:01, stanisc wrote:
> There shouldn't be CommitQueueImpl. This is supposed to be called
> ModelTypeWorker because it implements other interfaces in addition to
> CommitQueue.

Done.

[stanisc, 2015-08-31 17:42:19]

LGTM with a few comments (OK to address in the next patch).

https://codereview.chromium.org/1325453003/diff/60001/sync/engine/entity_trac...
File sync/engine/entity_tracker.h (right):

https://codereview.chromium.org/1325453003/diff/60001/sync/engine/entity_trac...
sync/engine/entity_tracker.h:23: // CommitQueue.
This should be ModelTypeWorker

https://codereview.chromium.org/1325453003/diff/60001/sync/test/engine/inject...
File sync/test/engine/injectable_sync_context_proxy.h (right):

https://codereview.chromium.org/1325453003/diff/60001/sync/test/engine/inject...
sync/test/engine/injectable_sync_context_proxy.h:32: CommitQueue* GetWorker();
Probably shouldn't be called GetWorker anymore

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/entity_trac...
File sync/engine/entity_tracker.h (right):

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/entity_trac...
sync/engine/entity_tracker.h:23: // CommitQueue.
Internal to ModelTypeWorker

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/entity_trac...
File sync/engine/entity_tracker_unittest.cc (right):

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/entity_trac...
sync/engine/entity_tracker_unittest.cc:19: // The EntityTracker is an
implementation detail of the CommitQueue.
CommitQueue -> ModelTypeWorker (which is implementation of CommitQueue) here and
below.

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
File sync/engine/model_type_processor.h (right):

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
sync/engine/model_type_processor.h:19: virtual void OnCommitCompleted(
Add a TODO comment to move OnConnect method here.

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
sync/engine/model_type_processor.h:22: virtual void OnUpdateReceived(
All methods of the interface will need comments. It is OK to do that in the next
patch together with OnConnect method.

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
File sync/engine/model_type_sync_proxy_impl.h (right):

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
sync/engine/model_type_sync_proxy_impl.h:24: class SYNC_EXPORT_PRIVATE
ModelTypeSyncProxyImpl : base::NonThreadSafe {
Add a TODO to derive this class from ModelTypeProcessor

[Gang Wu, 2015-08-31 22:38:06]

updated

https://codereview.chromium.org/1325453003/diff/60001/sync/engine/entity_trac...
File sync/engine/entity_tracker.h (right):

https://codereview.chromium.org/1325453003/diff/60001/sync/engine/entity_trac...
sync/engine/entity_tracker.h:23: // CommitQueue.
On 2015/08/31 17:42:19, stanisc wrote:
> This should be ModelTypeWorker

Done.

https://codereview.chromium.org/1325453003/diff/60001/sync/test/engine/inject...
File sync/test/engine/injectable_sync_context_proxy.h (right):

https://codereview.chromium.org/1325453003/diff/60001/sync/test/engine/inject...
sync/test/engine/injectable_sync_context_proxy.h:32: CommitQueue* GetWorker();
On 2015/08/31 17:42:19, stanisc wrote:
> Probably shouldn't be called GetWorker anymore

Done.

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/entity_trac...
File sync/engine/entity_tracker.h (right):

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/entity_trac...
sync/engine/entity_tracker.h:23: // CommitQueue.
On 2015/08/31 17:42:19, stanisc wrote:
> Internal to ModelTypeWorker

Done.

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/entity_trac...
File sync/engine/entity_tracker_unittest.cc (right):

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/entity_trac...
sync/engine/entity_tracker_unittest.cc:19: // The EntityTracker is an
implementation detail of the CommitQueue.
On 2015/08/31 17:42:19, stanisc wrote:
> CommitQueue -> ModelTypeWorker (which is implementation of CommitQueue) here
and
> below.

Done.

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
File sync/engine/model_type_processor.h (right):

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
sync/engine/model_type_processor.h:19: virtual void OnCommitCompleted(
On 2015/08/31 17:42:19, stanisc wrote:
> Add a TODO comment to move OnConnect method here.

Done.

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
sync/engine/model_type_processor.h:22: virtual void OnUpdateReceived(
On 2015/08/31 17:42:19, stanisc wrote:
> All methods of the interface will need comments. It is OK to do that in the
next
> patch together with OnConnect method.

Done.

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
File sync/engine/model_type_sync_proxy_impl.h (right):

https://codereview.chromium.org/1325453003/diff/80001/sync/engine/model_type_...
sync/engine/model_type_sync_proxy_impl.h:24: class SYNC_EXPORT_PRIVATE
ModelTypeSyncProxyImpl : base::NonThreadSafe {
On 2015/08/31 17:42:19, stanisc wrote:
> Add a TODO to derive this class from ModelTypeProcessor

Done.

[Gang Wu, 2015-08-31 23:31:11]

The CQ bit was checked by gangwu@chromium.org

[Gang Wu, 2015-08-31 23:31:11]

The patchset sent to the CQ was uploaded after l-g-t-m from stanisc@chromium.org
Link to the patchset: https://codereview.chromium.org/1325453003/#ps100001
(title: "update base on comments")

[commit-bot: I haz the power, 2015-08-31 23:31:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325453003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325453003/100001

[commit-bot: I haz the power, 2015-08-31 23:40:50]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-08-31 23:41:46]

Patchset 3 (id:??) landed as
https://crrev.com/5b0ee7313734fb1714457b19e24b07db88de9f79
Cr-Commit-Position: refs/heads/master@{#346521}