Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1325443002: Introduce localCaretRectOf() for VisiblePosition (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce localCaretRectOf() for VisiblePosition This patch introduces |localCaretRectOf()| function for |VisiblePosition| as replacement of |VisiblePosition::localCaretRect()| to simplify |VisiblePosition| class for ease of templataizing |VisiblePosition| class to introduce composed tree version of |VisiblePosition|, since an implementation of |VisiblePosition::localCaretRect()| can be implemented with public member functions of |VisiblePosition| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201409

Patch Set 1 : 2015-08-28T18:24:02 #

Patch Set 2 : 2015-08-28T23:08:19 Rebase after absoluteCaretRectBoundsOf() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M Source/core/editing/VisiblePosition.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-28 09:40:11 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-28 09:42:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325443002/1
5 years, 3 months ago (2015-08-28 10:01:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/94095)
5 years, 3 months ago (2015-08-28 10:06:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325443002/20001
5 years, 3 months ago (2015-08-28 14:09:20 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 16:15:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201409

Powered by Google App Engine
This is Rietveld 408576698