gpu/command_buffer/service/context_group.h - Issue 1325433003: command_buffer: Add support for creating non-WebGL ES 3 contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/context_group.h

Issue 1325433003: command_buffer: Add support for creating non-WebGL ES 3 contexts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/common/gles2_cmd_utils.h ('K') | « gpu/command_buffer/common/gles2_cmd_utils.cc ('k') | gpu/command_buffer/service/context_group.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/context_group.h

diff --git a/gpu/command_buffer/service/context_group.h b/gpu/command_buffer/service/context_group.h

index 504ae7e6196dd87dba7acad86240c70139cf468b..d3ecc5519f6f0e0bbb8adcc0901f055f0fb74771 100644

--- a/gpu/command_buffer/service/context_group.h

+++ b/gpu/command_buffer/service/context_group.h

@@ -47,12 +47,10 @@ class GPU_EXPORT ContextGroup : public base::RefCounted<ContextGroup> {

enum ContextType {

Zhenyao Mo 2015/08/28 17:16:25 Can we not redefine the ContextType? And just use

Kimmo Kinnunen 2015/08/31 12:23:13 Sure. (To me, they appeared as being in different

CONTEXT_TYPE_WEBGL1,

CONTEXT_TYPE_WEBGL2,

- CONTEXT_TYPE_OTHER,

- CONTEXT_TYPE_UNDEFINED

+ CONTEXT_TYPE_OPENGLES2,

+ CONTEXT_TYPE_OPENGLES3

};

- static ContextType GetContextType(unsigned webgl_version);

ContextGroup(

const scoped_refptr<MailboxManager>& mailbox_manager,

const scoped_refptr<MemoryTracker>& memory_tracker,