ui/events/base_event_utils.h - Issue 1325333002: Ignore inserting character with Search as a modifier on ChromeOS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/base_event_utils.h

Issue 1325333002: Ignore inserting character with Search as a modifier on ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: oshima's comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/renderer_host/native_web_keyboard_event_aura.cc ('k') | ui/events/base_event_utils.cc » ('j') | ui/events/base_event_utils.cc » ('J')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_EVENTS_BASE_EVENT_UTILS_H_	5 #ifndef UI_EVENTS_BASE_EVENT_UTILS_H_

6 #define UI_EVENTS_BASE_EVENT_UTILS_H_	6 #define UI_EVENTS_BASE_EVENT_UTILS_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "ui/events/events_base_export.h"	9 #include "ui/events/events_base_export.h"

10	10

11 // Common functions to be used for all platforms.	11 // Common functions to be used for all platforms.

12 namespace ui {	12 namespace ui {

13	13

14 // Generate an unique identifier for events.	14 // Generate an unique identifier for events.

15 EVENTS_BASE_EXPORT uint32 GetNextTouchEventId();	15 EVENTS_BASE_EXPORT uint32 GetNextTouchEventId();

16	16

	17 // Checks if \|flags\| contains system key modifiers. If \|allow_altgr\| is false

	18 // and AltGr is pressed, then \|flags\| is considered not to have any system

	19 // modifiers.

	20 EVENTS_BASE_EXPORT bool IsSystemKeyModifier(int flags, bool allow_altgr);
	kpschoedel 2015/09/04 18:06:13 I think the ‘allow_altgr’ parameter makes this har I think the ‘allow_altgr’ parameter makes this harder to follow at the call sites, and would prefer just \|IsSystemKeyModifier(flags)\| with the separate AltGr test retained in the one place that needs it. afakhry 2015/09/04 18:26:35 I agree. Done. Show quoted text On 2015/09/04 18:06:13, kpschoedel wrote: > I think the ‘allow_altgr’ parameter makes this harder to follow at the call > sites, and would prefer just \|IsSystemKeyModifier(flags)\| with the separate > AltGr test retained in the one place that needs it. I agree. Done.
	21

17 } // namespace ui	22 } // namespace ui

18	23

19 #endif // UI_EVENTS_BASE_EVENT_UTILS_H_	24 #endif // UI_EVENTS_BASE_EVENT_UTILS_H_

OLD	NEW