A block that establishes a new formatting context is pushed by floats.

A block that establishes a new formatting context is pushed by floats.

Only block containers that don't establish new formatting contexts are
allowed to ignore (and thus potentially overlap with) floats.

This obviously also applies inside multicol, but we had a check that actively
prevented that. This was some residue from CSS regions support (shared
implementation with multicol), which had a much more sophisticated positioning
implementation, which we've removed ages ago.

BUG=528179
R=jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201867

[Julien - ping for review, 2015-09-04 17:45:44]

lgtm

> Some types of block-level objects are affected by floats.

Can you make the short description even more hand wavy? :)

Seriously the rest of the description is great but this line is just
content-free.

https://codereview.chromium.org/1325323002/diff/1/LayoutTests/fast/multicol/f...
File LayoutTests/fast/multicol/float-beside-bfc.html (right):

https://codereview.chromium.org/1325323002/diff/1/LayoutTests/fast/multicol/f...
LayoutTests/fast/multicol/float-beside-bfc.html:7: </div>
Should we have a check-layout.js test instead of a ref-test here?

[mstensho (USE GERRIT), 2015-09-07 07:49:37]

Updated the commit comment too.

https://codereview.chromium.org/1325323002/diff/1/LayoutTests/fast/multicol/f...
File LayoutTests/fast/multicol/float-beside-bfc.html (right):

https://codereview.chromium.org/1325323002/diff/1/LayoutTests/fast/multicol/f...
LayoutTests/fast/multicol/float-beside-bfc.html:7: </div>
On 2015/09/04 17:45:44, Julien Chaffraix - PST wrote:
> Should we have a check-layout.js test instead of a ref-test here?

Sure - done.

[mstensho (USE GERRIT), 2015-09-07 07:49:40]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2015-09-07 07:49:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
jchaffraix@chromium.org
Link to the patchset: https://codereview.chromium.org/1325323002/#ps20001
(title: "Make check-layout test")

[commit-bot: I haz the power, 2015-09-07 07:49:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325323002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325323002/20001

[commit-bot: I haz the power, 2015-09-07 09:23:19]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201867