Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1325303004: Win Video Capture: add UYVY pixel format to Cr sink filter pin capabilities (Closed)

Created:
5 years, 3 months ago by mcasas
Modified:
5 years, 3 months ago
Reviewers:
emircan, aspoon
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Win Video Capture: add UYVY pixel format to Cr sink filter pin capabilities This format is already supported in the rest of the capture path. Bluefish 444 is the capture card using it. BUG=508413 TEST=Capture using a Bluefish 444 capture card Committed: https://crrev.com/6015405a94b144471eb0128779ad3c107192f445 Cr-Commit-Position: refs/heads/master@{#347861}

Patch Set 1 : #

Patch Set 2 : Using StringFromGUID2() ISO directly GUID #

Total comments: 1

Patch Set 3 : emircan@ nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M media/capture/video/win/sink_filter_win.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/sink_filter_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M media/capture/video/win/sink_input_pin_win.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M media/capture/video/win/sink_input_pin_win.cc View 1 2 7 chunks +27 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mcasas
emircan@ PTAL aspoon@ PTAL/FYI.
5 years, 3 months ago (2015-09-05 01:30:16 UTC) #3
aspoon
On 2015/09/05 01:30:16, mcasas wrote: > emircan@ PTAL > > aspoon@ PTAL/FYI. It's fine as ...
5 years, 3 months ago (2015-09-07 03:27:12 UTC) #4
mcasas
On 2015/09/07 03:27:12, aspoon wrote: > On 2015/09/05 01:30:16, mcasas wrote: > > emircan@ PTAL ...
5 years, 3 months ago (2015-09-08 16:40:19 UTC) #5
emircan
lgtm % nit. https://codereview.chromium.org/1325303004/diff/40001/media/capture/video/win/sink_input_pin_win.cc File media/capture/video/win/sink_input_pin_win.cc (right): https://codereview.chromium.org/1325303004/diff/40001/media/capture/video/win/sink_input_pin_win.cc#newcode39 media/capture/video/win/sink_input_pin_win.cc:39: const VideoCaptureFormat& SinkInputPin::ResultingFormat() { We can ...
5 years, 3 months ago (2015-09-08 18:09:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325303004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325303004/60001
5 years, 3 months ago (2015-09-09 01:11:59 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 3 months ago (2015-09-09 09:00:16 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6015405a94b144471eb0128779ad3c107192f445 Cr-Commit-Position: refs/heads/master@{#347861}
5 years, 3 months ago (2015-09-09 09:01:34 UTC) #11
mcasas
5 years, 3 months ago (2015-09-09 20:24:54 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1332653005/ by mcasas@chromium.org.

The reason for reverting is: Temptative fix for

https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester

timeout on 
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQuality/1

after 21330..

Powered by Google App Engine
This is Rietveld 408576698