Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1325303002: V8 Buildbot: Add auto-tag bot. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8 Buildbot: Add auto-tag bot. BUG=v8:4408 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296565

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M masters/master.client.v8.branches/master.cfg View 6 chunks +22 lines, -6 lines 0 comments Download
M masters/master.client.v8.branches/slaves.cfg View 1 chunk +8 lines, -0 lines 1 comment Download
M masters/master.client.v8/slaves.cfg View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1325303002/diff/1/masters/master.client.v8/slaves.cfg File masters/master.client.v8/slaves.cfg (left): https://codereview.chromium.org/1325303002/diff/1/masters/master.client.v8/slaves.cfg#oldcode335 masters/master.client.v8/slaves.cfg:335: for vm in [110, 129, 180, 181, 182, ...
5 years, 3 months ago (2015-09-04 12:19:06 UTC) #2
tandrii(chromium)
lgtm % though I don't yet understand where the slave is borrowed from => shouldn't ...
5 years, 3 months ago (2015-09-04 12:30:56 UTC) #3
Michael Achenbach
On 2015/09/04 12:30:56, tandrii(chromium) wrote: > lgtm % though I don't yet understand where the ...
5 years, 3 months ago (2015-09-04 12:41:00 UTC) #4
tandrii(chromium)
sorry, all good. LGTM https://codereview.chromium.org/1325303002/diff/1/masters/master.client.v8.branches/slaves.cfg File masters/master.client.v8.branches/slaves.cfg (right): https://codereview.chromium.org/1325303002/diff/1/masters/master.client.v8.branches/slaves.cfg#newcode43 masters/master.client.v8.branches/slaves.cfg:43: 'hostname': 'vm365-m3', and use it ...
5 years, 3 months ago (2015-09-04 12:51:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325303002/1
5 years, 3 months ago (2015-09-04 13:01:32 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 13:03:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296565

Powered by Google App Engine
This is Rietveld 408576698